From 404a8ca954b25461ebb15ffc20983ad1e6f393a6 Mon Sep 17 00:00:00 2001 From: Alexis Thaveau Date: Thu, 22 Jul 2021 17:56:23 +0200 Subject: [PATCH 1/3] (fix) Log fetching error --- app/services/karma-host-resolver.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/services/karma-host-resolver.ts b/app/services/karma-host-resolver.ts index a46ddab..1d6ad80 100644 --- a/app/services/karma-host-resolver.ts +++ b/app/services/karma-host-resolver.ts @@ -7,7 +7,7 @@ export class KarmaHostResolver implements IKarmaHostResolver { const resolvers = ips.map(ip => { const karmaClientUrl = `http://${ip}:${port}/context.json`; - console.log('NSUTR: fetching ' + karmaClientUrl); + console.log(`NSUTR: fetching ${karmaClientUrl}`); return this.http.getString({ url: karmaClientUrl, @@ -19,7 +19,10 @@ export class KarmaHostResolver implements IKarmaHostResolver { foundKarma = true; resolve(ip); } - }, () => undefined) + }, (err) => { + console.log(`Error NSUTR: fetching ${karmaClientUrl}`, err); + return undefined; + }) }); Promise.all(resolvers) From 545b5adf4f144c49a6aa6660f92546783f92c180 Mon Sep 17 00:00:00 2001 From: Alexis Thaveau Date: Thu, 22 Jul 2021 17:59:41 +0200 Subject: [PATCH 2/3] (fix) Log fetching error --- app/services/karma-host-resolver.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/services/karma-host-resolver.ts b/app/services/karma-host-resolver.ts index 1d6ad80..be61437 100644 --- a/app/services/karma-host-resolver.ts +++ b/app/services/karma-host-resolver.ts @@ -20,7 +20,7 @@ export class KarmaHostResolver implements IKarmaHostResolver { resolve(ip); } }, (err) => { - console.log(`Error NSUTR: fetching ${karmaClientUrl}`, err); + console.log(`NSUTR: error fetching ${karmaClientUrl}`, err); return undefined; }) }); From 4c37a2acd7c1f7376af8ea7c30fab4821f3814fd Mon Sep 17 00:00:00 2001 From: Alexis Thaveau Date: Fri, 23 Jul 2021 08:51:31 +0200 Subject: [PATCH 3/3] message with template string --- app/services/karma-host-resolver.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/services/karma-host-resolver.ts b/app/services/karma-host-resolver.ts index be61437..8f9f133 100644 --- a/app/services/karma-host-resolver.ts +++ b/app/services/karma-host-resolver.ts @@ -14,7 +14,7 @@ export class KarmaHostResolver implements IKarmaHostResolver { method: 'GET', timeout: 3000, }).then(() => { - console.log('NSUTR: found karma at ' + ip); + console.log(`NSUTR: found karma at ${ip}`); if (!foundKarma) { foundKarma = true; resolve(ip);