feat: move all source code to the app folder #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now
nativescript-dev-webpack
plugin requires automatically all (root|page)(.css|.xml|.js|.ts) files from the unit-test-runner. However, this behavior was changed and nownativescript-dev-webpack
plugin requires automatically all files except the files from App_Resources and .d.ts files. This led to the problem thatpreuninstall.js
andpostinstall.js
scripts are automatically required. These scripts requirenativescript-hook
. On the other sidenativescript-hook
has a dynamic require here https://github.com/NativeScript/nativescript-hook/blob/master/index.js#L56. As this dynamic require is not compatible with webpack's concept for dynamic requires, the following warning is shown:This PR do the followings:
nativescript-dev-webpack
will require automatically all files from app folder and the unneeded files (as postinstall and preuninstall) will not be required.before-liveSync
hook in order to throw an error when CLI <= 5.4.2 +nativescript-dev-webpack@latest
+nativescript-unit-test-runner@next
are used.Rel to: NativeScript/nativescript-cli#4821