From 753b88201b8c4e9537cd6895d382b3e91b36982f Mon Sep 17 00:00:00 2001 From: endarova Date: Wed, 28 Aug 2019 14:53:45 +0300 Subject: [PATCH 1/3] update path to aab --- tests/cli/build/android_app_bundle_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cli/build/android_app_bundle_tests.py b/tests/cli/build/android_app_bundle_tests.py index ae96d0d6..fb896456 100644 --- a/tests/cli/build/android_app_bundle_tests.py +++ b/tests/cli/build/android_app_bundle_tests.py @@ -65,7 +65,7 @@ def test_200_build_android_app_bundle(self): """Build app with android app bundle option. Verify the output(app.aab) and use bundletool to deploy on device""" path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build", "outputs", - "bundle", "debug", "app.aab") + "bundle", "debug", "app-debug.aab") Tns.build_android(self.app_path, aab=True, verify=False) # There is an issue at the moment that the path is not shown in log. @@ -95,7 +95,7 @@ def test_205_build_android_app_bundle_env_snapshot(self): # This test will not run on windows because env.snapshot option is not available on that OS path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build", - "outputs", "bundle", "release", "app.aab") + "outputs", "bundle", "release", "app-release.aab") # Configure app with snapshot optimisations source = os.path.join('assets', 'abdoid-app-bundle', 'app.gradle') From a7ae180184df2fcd190276a517fb55b9d715f850 Mon Sep 17 00:00:00 2001 From: endarova Date: Wed, 28 Aug 2019 15:24:45 +0300 Subject: [PATCH 2/3] uncomment fixed logs --- tests/cli/build/android_app_bundle_tests.py | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/tests/cli/build/android_app_bundle_tests.py b/tests/cli/build/android_app_bundle_tests.py index fb896456..c5a16b5b 100644 --- a/tests/cli/build/android_app_bundle_tests.py +++ b/tests/cli/build/android_app_bundle_tests.py @@ -67,11 +67,9 @@ def test_200_build_android_app_bundle(self): path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build", "outputs", "bundle", "debug", "app-debug.aab") - Tns.build_android(self.app_path, aab=True, verify=False) - # There is an issue at the moment that the path is not shown in log. - # TODO: uncomment this when the issue is fixed - # assert "The build result is located at:" in result.output - # assert path_to_aab in result.output + result = Tns.build_android(self.app_path, aab=True, verify=False) + assert "The build result is located at:" in result.output + assert path_to_aab in result.output assert File.exists(path_to_aab) # Verify app can be deployed on emulator via bundletool @@ -107,12 +105,10 @@ def test_205_build_android_app_bundle_env_snapshot(self): \nuseLibs: true,\nandroidNdkPath: \"$ANDROID_NDK_HOME\"""") # env.snapshot is applicable only in release build - Tns.build_android(self.app_path, aab=True, release=True, snapshot=True, + result = Tns.build_android(self.app_path, aab=True, release=True, snapshot=True, uglify=True, verify=False) - # There is an issue at the moment that the path is not shown in log. - # TODO: uncomment this when the issue is fixed - # assert "The build result is located at:" in result.output - # assert path_to_aab in result.output + assert "The build result is located at:" in result.output + assert path_to_aab in result.output assert File.exists(path_to_aab) # Verify app can be deployed on emulator via bundletool From 241cda66a79449beba334aeb0fd6a817a49dedad Mon Sep 17 00:00:00 2001 From: endarova Date: Wed, 28 Aug 2019 15:30:28 +0300 Subject: [PATCH 3/3] fix linter errors --- tests/cli/build/android_app_bundle_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cli/build/android_app_bundle_tests.py b/tests/cli/build/android_app_bundle_tests.py index c5a16b5b..9d4d0d02 100644 --- a/tests/cli/build/android_app_bundle_tests.py +++ b/tests/cli/build/android_app_bundle_tests.py @@ -106,7 +106,7 @@ def test_205_build_android_app_bundle_env_snapshot(self): # env.snapshot is applicable only in release build result = Tns.build_android(self.app_path, aab=True, release=True, snapshot=True, - uglify=True, verify=False) + uglify=True, verify=False) assert "The build result is located at:" in result.output assert path_to_aab in result.output assert File.exists(path_to_aab)