Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ff89a67

Browse files
authoredJan 22, 2019
chore: update pylint and fix errors (#13)
* chore: update pylint and fix errors
1 parent a4d3465 commit ff89a67

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+290
-222
lines changed
 

‎.pylintrc

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,19 @@ disable=print-statement,
140140
exception-escape,
141141
comprehension-escape,
142142
too-few-public-methods,
143-
useless-object-inheritance
143+
useless-object-inheritance,
144+
missing-docstring,
145+
fixme,
146+
no-else-return,
147+
no-self-use,
148+
unnecessary-lambda,
149+
too-many-arguments,
150+
too-many-locals,
151+
too-many-instance-attributes,
152+
keyword-arg-before-vararg,
153+
try-except-raise,
154+
cell-var-from-loop,
155+
wrong-import-order
144156

145157

146158
# Enable the message, report, category or checker with the given id(s). You can
@@ -239,14 +251,18 @@ docstring-min-length=-1
239251
# Naming style matching correct function names.
240252
function-naming-style=snake_case
241253

242-
# Regular expression matching correct function names. Overrides function-
243-
# naming-style.
254+
# Regular expression matching correct function names. Overrides function-naming-style.
244255
#function-rgx=
245256

246257
# Good variable names which should always be accepted, separated by a comma.
247258
good-names=i,
259+
id,
260+
f,
248261
j,
249262
k,
263+
v,
264+
x,
265+
y,
250266
ex,
251267
Run,
252268
_
@@ -265,8 +281,8 @@ inlinevar-naming-style=any
265281
method-naming-style=snake_case
266282

267283
# Regular expression matching correct method names. Overrides method-naming-
268-
# style.
269-
#method-rgx=
284+
# style
285+
method-rgx=(([a-z_][a-z0-9_]{2,})|(_[a-z0-9_]*)|(__[a-z][a-z0-9_]+__))$
270286

271287
# Naming style matching correct module names.
272288
module-naming-style=snake_case
@@ -361,7 +377,7 @@ ignore-comments=yes
361377
ignore-docstrings=yes
362378

363379
# Ignore imports when computing similarities.
364-
ignore-imports=no
380+
ignore-imports=yes
365381

366382
# Minimum lines number of a similarity.
367383
min-similarity-lines=4

‎.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,7 @@ install:
1010
- python -m pip install --upgrade pip
1111
- pip install --upgrade -r requirements.txt
1212
script:
13+
- python -m nose core_tests/utils -v -s --nologcapture --with-doctest --with-xunit
1314
- python -m flake8 --max-line-length=120 core core_tests data products tests
14-
- python -m nose core_tests/utils -v -s --nologcapture --with-doctest --with-xunit
15+
- python -m pylint --disable=locally-disabled --rcfile=.pylintrc core data products
16+
- find tests/cli | grep .py | grep -v .pyc | xargs python -m pylint --disable=locally-disabled --min-similarity-lines=15 --rcfile=.pylintrc

0 commit comments

Comments
 (0)
Please sign in to comment.