chore: re-write tests to be data driven

Author: dtopuzov

tests/cli/run/tests/test_run_scope_package_only.py

@@ -1,51 +1,66 @@
+"""
+Tests for tns run on project without tns-core-modules package.
+See https://github.com/NativeScript/nativescript-dev-webpack/issues/1089
+"""
 import os
-import unittest
+
+from parameterized import parameterized
 
 from core.base_test.tns_run_test import TnsRunTest
 from core.enums.os_type import OSType
 from core.enums.platform_type import Platform
 from core.settings import Settings
+from core.utils.device.simctl import Simctl
+from core.utils.file_utils import Folder
 from core.utils.npm import Npm
-from data.changes import Changes
 from data.templates import Template
 from products.nativescript.run_type import RunType
 from products.nativescript.tns import Tns
 from products.nativescript.tns_logs import TnsLogs
 
 
-class TestRunWithScopePackageOnly(TnsRunTest):
-    app_name = Settings.AppName.DEFAULT
-    app_path = os.path.join(Settings.TEST_RUN_HOME, Settings.AppName.DEFAULT)
+# noinspection PyUnusedLocal
+# noinspection PyMethodMayBeStatic
+class TestRunWithScopedPackages(TnsRunTest):
+    test_data = [
+        [Template.HELLO_WORLD_JS.name.replace('template-', ''), Template.HELLO_WORLD_JS],
+        # Skip TS projects because on TS projects we need to update all requires in the app in order to make it work.
+        # [Template.HELLO_WORLD_TS.name.replace('template-', ''), Template.HELLO_WORLD_TS],
+        [Template.HELLO_WORLD_NG.name.replace('template-', ''), Template.HELLO_WORLD_NG],
+        # Skip MasterDetailNG, it fails, need to be investigated.
+        # [Template.MASTER_DETAIL_NG.name.replace('template-', ''), Template.MASTER_DETAIL_NG],
+    ]
 
-    @classmethod
-    def setUpClass(cls):
-        TnsRunTest.setUpClass()
+    @parameterized.expand(test_data)
+    def test_scoped_package_only(self, app_name, template_info):
+        TnsRunTest.setUp(self)
 
         # Create app
-        Tns.create(app_name=cls.app_name, template=Template.HELLO_WORLD_NG.local_package, update=True)
-        Npm.uninstall(package='tns-core-modules', option='--save', folder=cls.app_path)
-        Npm.install(package=Settings.Packages.NATIVESCRIPT_CORE, option='--save --save-exact', folder=cls.app_path)
-        Tns.platform_add_android(app_name=cls.app_name, framework_path=Settings.Android.FRAMEWORK_PATH)
+        app_path = os.path.join(Settings.TEST_RUN_HOME, app_name)
+        Tns.create(app_name=app_name, template=template_info.local_package, update=True)
+        Npm.uninstall(package='tns-core-modules', option='--save', folder=app_path)
+        Npm.install(package=Settings.Packages.NATIVESCRIPT_CORE, option='--save --save-exact', folder=app_path)
+        Tns.platform_add_android(app_name=app_name, framework_path=Settings.Android.FRAMEWORK_PATH)
         if Settings.HOST_OS is OSType.OSX:
-            Tns.platform_add_ios(app_name=cls.app_name, framework_path=Settings.IOS.FRAMEWORK_PATH)
-
-    def setUp(self):
-        TnsRunTest.setUp(self)
-
-    @classmethod
-    def tearDownClass(cls):
-        TnsRunTest.tearDownClass()
+            Tns.platform_add_ios(app_name=app_name, framework_path=Settings.IOS.FRAMEWORK_PATH)
 
-    def test_100_run_android(self):
-        self.run_app(Platform.ANDROID, self.emu)
+        # Run Android
+        result = Tns.run_android(app_name=app_name, device=self.emu.id)
+        strings = TnsLogs.run_messages(app_name=app_name, run_type=RunType.UNKNOWN, platform=Platform.ANDROID)
+        TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings, timeout=300)
+        for text in template_info.texts:
+            self.emu.wait_for_text(text=text, timeout=60)
 
-    @unittest.skipIf(Settings.HOST_OS != OSType.OSX, 'iOS tests can be executed only on macOS.')
-    def test_100_run_ios(self):
-        self.run_app(Platform.IOS, self.sim)
+        # Run iOS
+        Tns.kill()
+        if Settings.HOST_OS is OSType.OSX:
+            Simctl.uninstall_all(simulator_info=self.sim)
+            result = Tns.run_ios(app_name=app_name, device=self.sim.id)
+            strings = TnsLogs.run_messages(app_name=app_name, run_type=RunType.UNKNOWN, platform=Platform.IOS)
+            TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings, timeout=300)
+            for text in template_info.texts:
+                self.sim.wait_for_text(text=text, timeout=60)
 
-    def run_app(self, platform, device):
-        result = Tns.run(app_name=self.app_name, platform=platform, emulator=True, wait=False)
-        strings = TnsLogs.run_messages(app_name=self.app_name, platform=platform, run_type=RunType.UNKNOWN,
-                                       device=device)
-        TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings, timeout=240)
-        device.wait_for_text(text=Changes.NGHelloWorld.TS.old_text)
+        # Cleanup
+        Folder.clean(os.path.join(Settings.TEST_RUN_HOME, app_name))
+        TnsRunTest.tearDown(self)