refactor: unit tests (#36)

Split `core_tests` on unit and e2e tests.

Some of product tests are also in unit tests (for example unit tests for log messages).

Execute all unit tests (instead of all utils tests) on Travis CI.

Notes:
- Some of the tests for sync massages are ignored because this feature is work in progress, but the plan is to enable them when they are green.

Author: dtopuzov

.travis.yml

@@ -10,7 +10,7 @@ install:
   - python -m pip install --upgrade pip
   - pip install --upgrade -r requirements.txt
 script:
-  - python -m nose core_tests/utils -v -s --nologcapture --with-doctest --with-xunit
+  - python -m nose core_tests/unit -v -s --nologcapture --with-doctest --with-xunit
   - python -m flake8 --max-line-length=120 core core_tests data products tests
   - python -m pylint --disable=locally-disabled --rcfile=.pylintrc core data products
   - find core_tests | grep .py | grep -v .pyc | xargs python -m pylint --disable=locally-disabled --min-similarity-lines=20 --rcfile=.pylintrc

core_tests/e2e/__init__.py

@@ -20,24 +20,25 @@ def test_02_get_prepare_messages(self):
         assert 'Project successfully prepared (Android)' in logs
         assert len(logs) == 4
 
-    def test_02_get_run_messages_first_run(self):
+    @unittest.skip('Failing.')
+    def test_10_get_run_messages_first_run(self):
         logs = TnsLogs.run_messages(app_name=Settings.AppName.DEFAULT,
                                     platform=Platform.ANDROID,
                                     run_type=RunType.FIRST_TIME)
-        # assert 'Skipping node_modules folder!' in logs
-        # assert 'Preparing project...' in logs
-        # assert 'Project successfully prepared (Android)' in logs
-        # assert 'Building project...' in logs
-        # assert 'Gradle build...' in logs
-        # assert 'Project successfully built.' in logs
-        # assert 'Installing on device' in logs
-        # assert 'Successfully installed on device' in logs
+        assert 'Skipping node_modules folder!' in logs
+        assert 'Preparing project...' in logs
+        assert 'Project successfully prepared (Android)' in logs
+        assert 'Building project...' in logs
+        assert 'Gradle build...' in logs
+        assert 'Project successfully built.' in logs
+        assert 'Installing on device' in logs
+        assert 'Successfully installed on device' in logs
         assert 'Restarting application on device' in logs
         assert 'Successfully synced application org.nativescript.TestApp on device' in logs
         assert 'ActivityManager: Start proc' in logs
         assert 'activity org.nativescript.TestApp/com.tns.NativeScriptActivity' in logs
 
-    def test_03_get_run_messages_sync_js(self):
+    def test_11_get_run_messages_sync_js(self):
         logs = TnsLogs.run_messages(app_name=Settings.AppName.DEFAULT,
                                     platform=Platform.ANDROID,
                                     run_type=RunType.INCREMENTAL,
@@ -50,7 +51,8 @@ def test_03_get_run_messages_sync_js(self):
         assert 'ActivityManager: Start proc' in logs
         assert 'activity org.nativescript.TestApp/com.tns.NativeScriptActivity' in logs
 
-    def test_04_get_run_messages_sync_js_bundle(self):
+    @unittest.skip('Failing.')
+    def test_12_get_run_messages_sync_js_bundle(self):
         logs = TnsLogs.run_messages(app_name=Settings.AppName.DEFAULT,
                                     platform=Platform.ANDROID,
                                     run_type=RunType.INCREMENTAL,
@@ -69,7 +71,8 @@ def test_04_get_run_messages_sync_js_bundle(self):
         assert 'Refreshing application on device' not in logs
         assert 'hot-update.json on device' not in logs
 
-    def test_05_get_run_messages_sync_js_hmr(self):
+    @unittest.skip('Failing.')
+    def test_13_get_run_messages_sync_js_hmr(self):
         logs = TnsLogs.run_messages(app_name=Settings.AppName.DEFAULT,
                                     platform=Platform.ANDROID,
                                     run_type=RunType.INCREMENTAL,
@@ -81,12 +84,10 @@ def test_05_get_run_messages_sync_js_hmr(self):
         assert 'hot-update.json on device' in logs
         assert 'The following modules were updated:' in logs
         assert 'Successfully applied update with hmr hash' in logs
-        # TODO: Uncomment when fixed in TnsLogs.run_messages()
-        # assert 'Refreshing application on device' in logs
+        assert 'Refreshing application on device' in logs
         assert 'Successfully synced application org.nativescript.TestApp on device' in logs
         assert 'Successfully transferred bundle.js on device' not in logs
-        # TODO: Uncomment when fixed in TnsLogs.run_messages()
-        # assert 'Restarting application on device' not in logs
+        assert 'Restarting application on device' not in logs
 
 
 if __name__ == '__main__':

core_tests/e2e/core/__init__.py

@@ -1,22 +1,21 @@
 import os
 import unittest
 
-from core.settings import Settings
 from core.utils.file_utils import File
 
 
 # noinspection PyMethodMayBeStatic
 class FileUtilsTests(unittest.TestCase):
+    current_folder = os.path.dirname(os.path.realpath(__file__))
 
     def test_01_read(self):
-        logs = os.path.join(Settings.TEST_RUN_HOME, 'core_tests', 'utils', 'file.txt')
+        logs = os.path.join(self.current_folder, 'resources', 'file.txt')
         assert 'Compiled successfully' in File.read(logs)
 
     def test_02_replace(self):
         # Path to files
-        base_path = os.path.join(Settings.TEST_RUN_HOME, 'core_tests', 'utils')
-        old_scss = os.path.join(base_path, 'app.android.scss')
-        new_scss = os.path.join(base_path, 'app.android.add_style.scss')
+        old_scss = os.path.join(self.current_folder, 'resources', 'app.android.scss')
+        new_scss = os.path.join(self.current_folder, 'resources', 'app.android.add_style.scss')
         old_value = 'Android here'
         new_value = 'Android here\n.page { background-color: red;}'
 

core_tests/device/adb_tests.py renamed to core_tests/e2e/core/adb_tests.py

@@ -18,8 +18,10 @@
 
 # noinspection PyMethodMayBeStatic,PyUnresolvedReferences
 class ImageUtilsTests(unittest.TestCase):
-    app_image = os.path.join(Settings.TEST_RUN_HOME, 'core_tests', 'app.png')
-    iphone_image = os.path.join(Settings.TEST_RUN_HOME, 'core_tests', 'screenshot.png')
+    current_folder = os.path.dirname(os.path.realpath(__file__))
+
+    app_image = os.path.join(current_folder, 'resources', 'app.png')
+    iphone_image = os.path.join(current_folder, 'resources', 'screenshot.png')
     blue = numpy.array([255, 188, 48])
     white = numpy.array([255, 255, 255])