Skip to content

Commit 4db9fbc

Browse files
authored
fix: update app bundle path (#347)
* update path to aab * uncomment fixed logs * fix linter errors
1 parent 4f71c9b commit 4db9fbc

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

tests/cli/build/android_app_bundle_tests.py

+9-13
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,11 @@ def test_200_build_android_app_bundle(self):
6565
"""Build app with android app bundle option. Verify the output(app.aab) and use bundletool
6666
to deploy on device"""
6767
path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build", "outputs",
68-
"bundle", "debug", "app.aab")
68+
"bundle", "debug", "app-debug.aab")
6969

70-
Tns.build_android(self.app_path, aab=True, verify=False)
71-
# There is an issue at the moment that the path is not shown in log.
72-
# TODO: uncomment this when the issue is fixed
73-
# assert "The build result is located at:" in result.output
74-
# assert path_to_aab in result.output
70+
result = Tns.build_android(self.app_path, aab=True, verify=False)
71+
assert "The build result is located at:" in result.output
72+
assert path_to_aab in result.output
7573
assert File.exists(path_to_aab)
7674

7775
# Verify app can be deployed on emulator via bundletool
@@ -95,7 +93,7 @@ def test_205_build_android_app_bundle_env_snapshot(self):
9593
# This test will not run on windows because env.snapshot option is not available on that OS
9694

9795
path_to_aab = os.path.join(self.app_name, "platforms", "android", "app", "build",
98-
"outputs", "bundle", "release", "app.aab")
96+
"outputs", "bundle", "release", "app-release.aab")
9997

10098
# Configure app with snapshot optimisations
10199
source = os.path.join('assets', 'abdoid-app-bundle', 'app.gradle')
@@ -107,12 +105,10 @@ def test_205_build_android_app_bundle_env_snapshot(self):
107105
\nuseLibs: true,\nandroidNdkPath: \"$ANDROID_NDK_HOME\"""")
108106

109107
# env.snapshot is applicable only in release build
110-
Tns.build_android(self.app_path, aab=True, release=True, snapshot=True,
111-
uglify=True, verify=False)
112-
# There is an issue at the moment that the path is not shown in log.
113-
# TODO: uncomment this when the issue is fixed
114-
# assert "The build result is located at:" in result.output
115-
# assert path_to_aab in result.output
108+
result = Tns.build_android(self.app_path, aab=True, release=True, snapshot=True,
109+
uglify=True, verify=False)
110+
assert "The build result is located at:" in result.output
111+
assert path_to_aab in result.output
116112
assert File.exists(path_to_aab)
117113

118114
# Verify app can be deployed on emulator via bundletool

0 commit comments

Comments
 (0)