Skip to content

Commit 3c14249

Browse files
test
1 parent c17a38a commit 3c14249

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

data/sync/hello_world_js.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def preview_sync_hello_world_js_ts(app_type, app_name, platform, device, bundle=
191191

192192
# Edit CSS file and verify changes are applied
193193
Sync.replace(app_name=app_name, change_set=css_change)
194-
strings = TnsLogs.preview_file_changed_messages(platform=platform, bundle=bundle, device=device,
194+
strings = TnsLogs.preview_file_changed_messages(bundle=bundle, device=device,
195195
hmr=hmr, file_name='app.css', instrumented=instrumented)
196196
if hmr and instrumented and Settings.HOST_OS != OSType.WINDOWS:
197197
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings,
@@ -202,7 +202,7 @@ def preview_sync_hello_world_js_ts(app_type, app_name, platform, device, bundle=
202202

203203
# Edit JS file and verify changes are applied
204204
Sync.replace(app_name=app_name, change_set=js_change)
205-
strings = TnsLogs.preview_file_changed_messages(platform=platform, bundle=bundle, hmr=hmr, device=device,
205+
strings = TnsLogs.preview_file_changed_messages(bundle=bundle, hmr=hmr, device=device,
206206
file_name=js_file, instrumented=instrumented)
207207
if hmr and instrumented and Settings.HOST_OS != OSType.WINDOWS:
208208
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings,
@@ -213,7 +213,7 @@ def preview_sync_hello_world_js_ts(app_type, app_name, platform, device, bundle=
213213

214214
# Edit XML file and verify changes are applied
215215
Sync.replace(app_name=app_name, change_set=xml_change)
216-
strings = TnsLogs.preview_file_changed_messages(platform=platform, bundle=bundle, device=device,
216+
strings = TnsLogs.preview_file_changed_messages(bundle=bundle, device=device,
217217
hmr=hmr, file_name='main-page.xml', instrumented=instrumented)
218218
if hmr and instrumented and Settings.HOST_OS != OSType.WINDOWS:
219219
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings,

products/nativescript/tns_logs.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,8 @@ def __webpack_messages():
247247

248248
@staticmethod
249249
def preview_initial_messages(device, bundle=True, hmr=False, instrumented=False):
250-
logs = ["Start sending initial files for device \'{0}\'".format(str(device.model)),
251-
"Successfully sent initial files for device \'{0}\'".format(str(device.model))]
250+
logs = ["Start sending initial files for device {0}".format(str(device.model)),
251+
"Successfully sent initial files for device {0}".format(str(device.model))]
252252
if bundle or hmr:
253253
logs.extend(TnsLogs.__webpack_messages())
254254
if instrumented:
@@ -258,7 +258,7 @@ def preview_initial_messages(device, bundle=True, hmr=False, instrumented=False)
258258
@staticmethod
259259
def preview_file_changed_messages(device, file_name, run_type=RunType.INCREMENTAL,
260260
bundle=True, hmr=True, instrumented=False):
261-
logs = ["Start syncing changes for device \'{0}\'".format(str(device.model))]
261+
logs = ["Start syncing changes for device {0}".format(str(device.model))]
262262
if bundle or hmr:
263263
logs.extend(TnsLogs.__webpack_messages())
264264
logs.append(file_name)

tests/cli/preview/templates/hello_word_js_tests.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def setUpClass(cls):
3131
cls.emu_API24 = DeviceManager.Emulator.ensure_available(Settings.Emulators.EMU_API_24)
3232

3333
# Download Preview and Playground packages
34-
Preview.get_app_packages()
34+
# Preview.get_app_packages()
3535

3636
# Install Preview and Playground
3737
Preview.install_preview_app(cls.emu, Platform.ANDROID)
@@ -96,7 +96,7 @@ def test_210_tns_preview_android_livesync_on_two_emulators(self):
9696
log = File.read(result.log_file)
9797
url = Preview.get_url(log)
9898
Preview.run_url(url=url, device=self.emu)
99-
strings = TnsLogs.preview_initial_messages(platform=Platform.ANDROID)
99+
strings = TnsLogs.preview_initial_messages(device=self.emu)
100100
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings)
101101
self.emu.wait_for_text(text=Changes.JSHelloWord.JS.old_text, timeout=90)
102102

@@ -107,7 +107,7 @@ def test_210_tns_preview_android_livesync_on_two_emulators(self):
107107
Preview.run_url(url=url, device=self.emu_API24)
108108
# Here use bundle=False because on consecutive preview build is not executed again
109109
# and no bundle messages are displayed in log
110-
strings = TnsLogs.preview_initial_messages(platform=Platform.ANDROID, bundle=False)
110+
strings = TnsLogs.preview_initial_messages(device=self.emu, bundle=False)
111111
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings)
112112
self.emu_API24.wait_for_text(text=Changes.JSHelloWord.JS.old_text)
113113

@@ -136,7 +136,7 @@ def test_210_tns_preview_on_simulator_and_emulator_livesync(self):
136136
log = File.read(result.log_file)
137137
url = Preview.get_url(log)
138138
Preview.run_url(url=url, device=self.emu)
139-
strings = TnsLogs.preview_initial_messages(platform=Platform.ANDROID)
139+
strings = TnsLogs.preview_initial_messages(device=self.emu)
140140
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings)
141141
self.emu.wait_for_text(text=Changes.JSHelloWord.JS.old_text)
142142

@@ -145,7 +145,7 @@ def test_210_tns_preview_on_simulator_and_emulator_livesync(self):
145145

146146
# Preview on simulator
147147
Preview.run_url(url=url, device=self.sim)
148-
strings = TnsLogs.preview_initial_messages(platform=Platform.IOS)
148+
strings = TnsLogs.preview_initial_messages(device=self.sim)
149149
TnsLogs.wait_for_log(log_file=result.log_file, string_list=strings)
150150
self.sim.wait_for_text(text=Changes.JSHelloWord.JS.old_text)
151151

0 commit comments

Comments
 (0)