fix: preview tests (#54)

* Try to install preview on ios only on mac

* update  timeout to fix slow install of app on windows

* Update logs according to latest runtime. Add dismiss alert method for ios runs

* revert timeout

* fix linter errors

Author: endarova

core/utils/device/adb.py

@@ -178,6 +178,6 @@ def install(apk_path, device_id):
         :param apk_path: File path to .apk.
         :param device_id: Device id.
         """
-        result = Adb.__run_adb_command(command='install -r {0} {1}'.format(apk_path, device_id))
+        result = Adb.__run_adb_command(command='install -r {0} {1}'.format(apk_path, device_id), timeout=60)
         assert 'Success' in result.output, 'Failed to install {0}. Output: {1}'.format(apk_path, result.output)
         Log.info('{0} installed successfully on {1}.'.format(apk_path, device_id))

data/sync/hello_world_js.py

@@ -3,8 +3,10 @@
 """
 
 import os
+import time
 
 from core.enums.app_type import AppType
+from core.enums.platform_type import Platform
 from core.settings import Settings
 from core.utils.file_utils import File
 from core.utils.wait import Wait
@@ -137,6 +139,10 @@ def preview_hello_world_js_ts(app_name, platform, device, bundle=False, hmr=Fals
     log = File.read(result.log_file)
     url = Preview.get_url(log)
     Preview.run_app(url, device.id, platform)
+    # When you run preview on ios simulator on first run confirmation dialog is showh. This script will dismiss it
+    if platform == Platform.IOS:
+        time.sleep(2)
+        Preview.dismiss_simulator_alert()
 
     # Verify logs
     strings = TnsLogs.preview_initial_messages(platform=platform, hmr=hmr, bundle=bundle, instrumented=instrumented)

products/nativescript/tns_logs.py

@@ -239,7 +239,6 @@ def preview_file_changed_messages(platform, file_name, run_type=RunType.INCREMEN
         else:
             logs.append('Successfully synced {0} for platform {1}'.format(file_name, str(platform)))
         if hmr:
-            logs.append('Successfully synced bundle.')
             logs.append('hot-update.json')
             logs.append('HMR: Checking for updates to the bundle with hmr hash')
             logs.append('HMR: The following modules were updated:')

tests/cli/preview/templates/hello_word_js_tests.py

@@ -27,8 +27,9 @@ def setUpClass(cls):
 
         # Install Preview and Playground
         Preview.install_preview_app(cls.emu, Platform.ANDROID)
-        Preview.install_preview_app(cls.sim, Platform.IOS)
-        Preview.install_playground_app(cls.sim, Platform.IOS)
+        if Settings.HOST_OS is OSType.OSX:
+            Preview.install_preview_app(cls.sim, Platform.IOS)
+            Preview.install_playground_app(cls.sim, Platform.IOS)
 
         # Create app
         Tns.create(app_name=cls.app_name, template=Template.HELLO_WORLD_JS.local_package, update=True)