Skip to content

Commit 3c0ed50

Browse files
author
Dimitar Todorov
committed
Fix: demo-js ios tests
1 parent 282201e commit 3c0ed50

File tree

3 files changed

+22
-8
lines changed

3 files changed

+22
-8
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ matrix:
182182
script:
183183
- npm i -g appium
184184
- cd demo && npm i
185-
- travis_wait travis_retry npm run e2e -- --runType sim11iPhone6 --sauceLab --appPath $IOS_PACKAGE_JS
185+
- travis_wait travis_retry npm run e2e -- --runType sim12iPhoneX --sauceLab --appPath $IOS_PACKAGE_JS
186186
- os: linux
187187
env:
188188
- iOS="12.0"

demo/e2e/config/appium.capabilities.json

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,18 @@
4141
"deviceName": "iPhone 6",
4242
"appium-version": "1.7.1",
4343
"app": ""
44+
},
45+
"sim12iPhoneX":{
46+
"platformName": "iOS",
47+
"platformVersion": "12.0",
48+
"deviceName": "iPhone X",
49+
"appium-version": "1.9.1",
50+
"app": "",
51+
"noReset": true,
52+
"fullReset": false,
53+
"density": 3,
54+
"offsetPixels": 87,
55+
"idleTimeout": 120,
56+
"automationName": "Appium"
4457
}
4558
}

demo/e2e/test.e2e.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,13 @@ describe("Imagepicker", async function () {
6868
await imagesFolder.click();
6969
}
7070
} else {
71-
const cameraRollFolder = await driver.findElementByText(imagesFolderNameIos);
71+
const cameraRollFolder = await driver.findElementByAccessibilityId(imagesFolderNameIos);
7272
await cameraRollFolder.click();
7373
}
7474

75-
const pickedImage = await driver.findElementByClassName(driver.locators.image);
76-
await pickedImage.click();
75+
const imageLocator = isAndroid ? "android.widget.ImageView" : "XCUIElementTypeCell";
76+
const image = await driver.findElementByClassName(imageLocator);
77+
await image.tap();
7778

7879
pickSingleButton = await driver.findElementByText(pickSingleButtonText, SearchOptions.contains);
7980
expect(pickSingleButton).to.exist;
@@ -96,12 +97,12 @@ describe("Imagepicker", async function () {
9697
await cameraRollFolder.click();
9798
}
9899

99-
const allImages = await driver.findElementsByClassName(driver.locators.image);
100-
101100
if (isAndroid) {
102-
await allImages[8].hold(); // third image
103-
await allImages[4].click(); // second image
101+
const allImages = await driver.findElementsByClassName("android.widget.ImageView");
102+
await allImages[5].hold(); // second Image
103+
await allImages[2].click(); // first image
104104
} else {
105+
const allImages = await driver.findElementsByClassName("XCUIElementTypeCell");
105106
await allImages[0].click(); // first image
106107
await allImages[1].click(); // second image
107108
}

0 commit comments

Comments
 (0)