Upgrade to 1.9.0 version of the native library (#77)

* chore: Upgrade native library to 1.9.0

* chore: Upgrade demo with import for native Fresco typings
chore: Add npmignore
fix: Add warrning message if imageUri is set to incorrect value
chore: Update tsconfig file according to plugin seed

* chore: Remove commented out code

* chore: Bump version

* chore: Returned productFlavors

* chore: Returned the 'IAnimatedImage' to be used rather than native class in wrapper

* docs: Update readme with migration guide from 3.x.x to 4.x.x

* chore: Add example that shows how to manually start animating image

* chore: Rename interfaces to TypeScript best practices
docs: Update readme with migration process
chore: Made demo logs more informative

* chore: Rename interface name in d.ts

Author: VladimirAmiorkov

README.md

@@ -97,8 +97,19 @@ Use `fresco` in the XML definition of the page as follows:
 ## Examples
 You can refer the [demo-angular](https://github.com/NativeScript/nativescript-fresco/tree/master/demo-angular) folder of the repo for runnable {N} project that demonstrates the nativescript-fresco plugin with all of its features in action.
 
+## Migrating from 3.x.x to 4.x.x
+- If you are using the `AnimatedImage` class you can continue to cast to this type just note that it is now an interface rather than a class
+- If you are using the `IAnimatedImage` interface simply change all of your references to be `AnimatedImage`
+- If you are using the `IImageInfo` interface simply change all of your references to be `ImageInfo`
+- If you are using the `IError` interface simply change all of your references to be `FrescoError`
+
 ## Features
 
+### Native Fresco library typings
+If you find yourself in the need to access directly the native library of the nativescript-fresco plugin you can import the android.d.ts from the plugin in your `references.d.ts`:
+
+```/// <reference path="./node_modules/nativescript-fresco/android.d.ts" />```
+
 As documented by the Fresco library setting the **height and width** are **mandatory**, more details on this topic could be found [here](http://frescolib.org/docs/using-drawees-xml.html#height-and-width-mandatory). So the first this you should do when declaring the FrescoDrawee is set its *width* and *height* attributes or set only one of them and set the FrescoDrawee's **aspectRatio**. The width and height of the FrescoDrawee in your {N} application supports percentages which makes it possible to declare for example *width="50%"* and *aspectRatio="1.33"* achieving exactly 50% width with dynamically calculated height based on the aspect ration of the loaded image from the *imageUri*.
 
 ### Basic attributes

demo/app/examples/animating.ts

@@ -0,0 +1,15 @@
+import { FrescoDrawee, FinalEventData, AnimatedImage} from "nativescript-fresco";
+import { writeToOutputLabel } from "./appLogger";
+
+export function onFinalImageSet(args: FinalEventData) {
+    let drawee = args.object as FrescoDrawee;
+    let message = ">>>>>> onFinalImageSet ";
+    writeToOutputLabel(drawee, message);
+    let animatedImage = args.animatable as AnimatedImage;
+    if (animatedImage) {
+        writeToOutputLabel(drawee, ">>>>>> animatedImage: isRunning(): " + animatedImage.isRunning());
+        writeToOutputLabel(drawee, ">>>>>> animatedImage: start() ");
+        animatedImage.start();
+        writeToOutputLabel(drawee, ">>>>>> animatedImage: isRunning(): " + animatedImage.isRunning());
+    }
+}

demo/app/examples/animating.xml

@@ -0,0 +1,12 @@
+<ScrollView>
+    <GridLayout rows="*, auto">
+        <fresco:FrescoDrawee xmlns:fresco="nativescript-fresco" 
+                            width="119"
+                            height="120"
+                            placeholderImageUri="res://ns_logo"
+                            verticalAlignment="top"
+                            imageUri="res://animation"
+                            finalImageSet="onFinalImageSet"/>
+        <Label id="outputLabel" text="output: " row="1" textWrap="true"/>
+    </GridLayout>
+</ScrollView>

demo/app/examples/failure.ts

@@ -5,7 +5,6 @@ import { writeToOutputLabel } from "./appLogger";
 
 export function onFailure(args: FailureEventData) {
     let drawee = args.object as FrescoDrawee;
-    let message = ">>>>> onFailure ";
-    console.log(message);
+    let message = ">>>>> onFailure " + args.error;
     writeToOutputLabel(drawee, message);
 }

demo/app/home/home-page.xml

@@ -75,6 +75,11 @@
             <examples:autoplayanimations />
         </TabViewItem.view>
       </TabViewItem>
+      <TabViewItem title="animating">
+        <TabViewItem.view>
+            <examples:animating />
+        </TabViewItem.view>
+      </TabViewItem>
       <TabViewItem title="events">
         <TabViewItem.view>
             <examples:events />

demo/package.json

@@ -31,6 +31,7 @@
     "raw-loader": "~0.5.1",
     "resolve-url-loader": "~2.3.0",
     "typescript": "~2.7.2",
+    "tns-platform-declarations": "^4.1.0",
     "uglifyjs-webpack-plugin": "~1.2.4",
     "webpack": "~4.5.0",
     "webpack-bundle-analyzer": "^2.9.1",

demo/references.d.ts

@@ -0,0 +1,2 @@
+/// <reference path="./node_modules/tns-platform-declarations/android.d.ts" />
+/// <reference path="./node_modules/nativescript-fresco/android.d.ts" />

demo/tsconfig.json

@@ -23,6 +23,7 @@
     },
     "exclude": [
         "node_modules",
+        "../src/node_modules",
         "platforms"
     ]
 }

src/.npmignore

@@ -0,0 +1,5 @@
+*.map
+*.ts
+!*.d.ts
+tsconfig.json
+sync

src/nativescript-fresco.android-map.d.ts renamed to src/android.d.ts

@@ -1,29 +1,3 @@
-declare namespace android {
-    namespace net {
-        class Uri {
-            static parse(orientation);
-        }
-
-        namespace Uri {
-            class Builder {
-                scheme(scheme: string);
-                path(path: string);
-            }
-        }
-    }
-
-    namespace graphics {
-        namespace drawable {
-            class BitmapDrawable {
-                constructor(resources, image);
-            }
-        }
-        class Color {
-            static parseColor(color: string);
-        }
-    }
-}
-
 declare namespace com {
     namespace facebook {
         namespace drawee {
@@ -172,11 +146,11 @@ declare namespace com {
 
             namespace core {
                 class ImagePipeline {
-                    isInBitmapMemoryCache(uri: string): boolean;
-                    isInDiskCacheSync(uri: string): boolean;
-                    evictFromMemoryCache(uri: string): void;
-                    evictFromDiskCache(uri: string): void;
-                    evictFromCache(uri: string): void;
+                    isInBitmapMemoryCache(uri: android.net.Uri): boolean;
+                    isInDiskCacheSync(uri: android.net.Uri): boolean;
+                    evictFromMemoryCache(uri: android.net.Uri): void;
+                    evictFromDiskCache(uri: android.net.Uri): void;
+                    evictFromCache(uri: android.net.Uri): void;
                     clearCaches(): void;
                     clearMemoryCaches(): void;
                     clearDiskCaches(): void;
@@ -197,20 +171,3 @@ declare namespace com {
         }
     }
 }
-
-declare namespace java {
-    namespace lang {
-        class String {
-            static valueOf(identifier);
-        }
-
-        class Class {
-            getName(): string;
-        }
-
-        class Throwable {
-            getClass(): java.lang.Class;
-            getMessage(): string;
-        }
-    }
-}

src/index.d.ts

@@ -186,7 +186,7 @@ export class ImageInfo {
 /**
 * Interface of the common abstraction behind a platform specific error object that is used by the FrescoDrawee's events.
 */
-export interface IError {
+export interface FrescoError {
     /**
     * Returns the message of the Error.
     */
@@ -306,7 +306,7 @@ export class FailureEventData {
 /**
 * Interface of the common abstraction behind a platform specific animated image object.
 */
-export interface IAnimatedImage {
+export interface AnimatedImage {
     /**
      * Starts the AnimatedDrawable image.
      */
@@ -322,27 +322,6 @@ export interface IAnimatedImage {
      */
     isRunning(): boolean;
 }
-
-/**
- * Encapsulates the common abstraction behind a platform specific animated image object.
- */
-export class AnimatedImage {
-    /**
-     * Starts the AnimatedImage image.
-     */
-    start(): void;
-
-    /**
-     * Stops the AnimatedImage image.
-     */
-    stop(): void;
-
-    /**
-     * Returns boolean value representing the if the AnimatedImage's is being animated.
-     */
-    isRunning(): boolean;
-}
-
 /**
  * The entry point for the image pipeline..
  */

src/nativescript-fresco-common.d.ts

@@ -1,4 +1,3 @@
-/// <reference path="references.d.ts" />
 import { View, Property } from "tns-core-modules/ui/core/view";
 import * as observableModule from "tns-core-modules/data/observable";
 export declare namespace ScaleType {
@@ -11,16 +10,16 @@ export declare namespace ScaleType {
     const FitXY = "fitXY";
     const FocusCrop = "focusCrop";
 }
-export interface IAnimatedImage {
+export interface AnimatedImage {
     start(): void;
     stop(): void;
     isRunning(): boolean;
 }
-export interface IImageInfo {
+export interface ImageInfo {
     getHeight(): number;
     getWidth(): number;
 }
-export interface IError {
+export interface FrescoError {
     getMessage(): string;
     getErrorType(): string;
     toString(): string;

src/nativescript-fresco-common.ts

@@ -1,5 +1,3 @@
-/// <reference path="references.d.ts" />
-
 import { View, Property, booleanConverter } from "tns-core-modules/ui/core/view";
 import * as observableModule from "tns-core-modules/data/observable";
 
@@ -14,25 +12,25 @@ export namespace ScaleType {
     export const FocusCrop = "focusCrop";
 }
 
-export interface IAnimatedImage {
+export interface AnimatedImage {
     start(): void;
     stop(): void;
     isRunning(): boolean;
 }
 
-export interface IImageInfo {
+export interface ImageInfo {
     getHeight(): number;
     getWidth(): number;
 }
 
-export interface IError {
+export interface FrescoError {
     getMessage(): string;
     getErrorType(): string;
     toString(): string;
 }
 
 export interface ImagePipelineConfigSetting {
-  isDownsampleEnabled?: boolean;
+    isDownsampleEnabled?: boolean;
 }
 
 export class EventData implements observableModule.EventData {

src/nativescript-fresco.android.d.ts

@@ -14,14 +14,7 @@ export declare class ImagePipeline {
     clearDiskCaches(): void;
     android: any;
 }
-export interface AnimatedImage extends com.facebook.imagepipeline.animated.base.AnimatedDrawable, commonModule.IAnimatedImage {
-    new (): AnimatedImage;
-    start(): void;
-    stop(): void;
-    isRunning(): boolean;
-}
-export declare let AnimatedImage: AnimatedImage;
-export declare class FrescoError implements commonModule.IError {
+export declare class FrescoError implements commonModule.FrescoError {
     private _stringValue;
     private _message;
     private _errorType;
@@ -35,7 +28,7 @@ export interface QualityInfo {
     isOfFullQuality(): any;
     isOfGoodEnoughQuality(): any;
 }
-export declare class ImageInfo implements commonModule.IImageInfo {
+export declare class ImageInfo implements commonModule.ImageInfo {
     private _nativeImageInfo;
     constructor(imageInfo: any);
     getHeight(): number;
@@ -46,7 +39,7 @@ export declare class FinalEventData extends commonModule.EventData {
     private _imageInfo;
     private _animatable;
     imageInfo: ImageInfo;
-    animatable: commonModule.IAnimatedImage;
+    animatable: commonModule.AnimatedImage;
 }
 export declare class IntermediateEventData extends commonModule.EventData {
     private _imageInfo;