This repository was archived by the owner on Aug 7, 2021. It is now read-only.
chore: entryPath check should work on Windows #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous commit we've changed the check when to execute the `bundle-config-loader` to be based on full path. However, the created RegExp does not match anything on Windows as the paths contain `\`, which are used for escape symbol inside RegExp. Escape the `\` and update all webpack configs with the new RegExp.
ghost
added
the
DimitarTachev
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous commit we've changed the check when to execute the
bundle-config-loaderto be based on full path. However, the created RegExp does not match anything on Windows as the paths contain\, which are used for escape symbol inside RegExp.Escape the
\and update all webpack configs with the new RegExp.PR Checklist
What is the current behavior?
Application built with Webpack on Windows fail at runtime.
What is the new behavior?
You can build applications with Webpack on all OSes.
Fixes/Implements/Closes #[Issue Number].