This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: show message for stopping webpack only when it has been started #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the message `Stopping webpack watch` is printed whenever CLI executes `after-watch` hooks, i.e. when user runs `tns run <platform>` and sends Ctrl+C, the message is shown. However, we have not started any webpack process, so there's nothing to stop. Print the message only when webpack process had been started. Also print it only when `--log trace` is used.
Fatme
approved these changes
Feb 25, 2019
|
test package_version#latest |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
sis0k0
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the message
Stopping webpack watchis printed whenever CLI executesafter-watchhooks, i.e. when user runstns run <platform>and sends Ctrl+C, the message is shown. However, we have not started any webpack process, so there's nothing to stop.Print the message only when webpack process had been started. Also print it only when
--log traceis used.PR Checklist
What is the current behavior?
Message
Stopping webpack watchis shown when you executetns run <platform>(without--bundle) and pressCtrl + C.What is the new behavior?
Message
Stopping webpack watchis shown only when you executetns run <platform> --bundleand pressCtrl + C.Fixes/Implements/Closes #[Issue Number].