This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: initial compilation always generates same compilation hash #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test package_version#latest |
DimitarTachev
approved these changes
Feb 21, 2019
KristianDD
force-pushed
the
kddimitrov/fix-same-hash-with-new-compilator
branch
from
a62e322 to
8fbcc1d
Compare
|
test package_version#latest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently every start of the compilation will generate the same compilation hash for the same content. This hash is also used to chain Hot Module Reloads.
To reproduce:
1 Generate a HMR patch which breaks the app, then kill the compiler.
2 Revert the change and restart the compiler the application remains broken.
This is happening, because the hash of the second compilation is the same as the initial and it decides to apply the patch causing the error.
What is the new behavior?
Every initial compiler run creates unique compilation hash.
Fixes/Implements/Closes NativeScript/nativescript-cli#4123