This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: project's package.json indentation is not persisted #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
force-pushed
the
vladimirov/persist-package-json-indent
branch
from
b2b2146 to
bd9a4eb
Compare
|
run ci |
Fatme
reviewed
Dec 7, 2018
| const getIndentationCharacter = (jsonContent) => { | ||
| const defaultIndentation = " "; | ||
| const matches = jsonContent.match(/{\r*\n*(\W*)"/m); | ||
| return matches && matches[1]; |
There was a problem hiding this comment.
return (matches && matches[1]) || defaultIndentation
There was a problem hiding this comment.
In fact we do not need default indentation, I've forgotten to remove the variable. I've already added a unit test that verifies we work correctly when the matches[1] group is undefined.
Fatme
approved these changes
Dec 7, 2018
vchimev
approved these changes
Dec 7, 2018
sis0k0
approved these changes
Dec 7, 2018
rosen-vladimirov
force-pushed
the
vladimirov/persist-package-json-indent
branch
from
bd9a4eb to
3df741f
Compare
In case project's package.json uses tabs or multiple spaces for indentation, the postinstall script of nativescript-dev-webpack overwrites it with two spaces whenever it is executed. The problem is that the plugin tries to modify the package.json and persists it on every operation. Fix the behavior by checking the indentation character and use it when stringifying the content. Also compare the current content of the file with the one we will write and skip the write operation in case they match. Add unit tests for the new methods.
rosen-vladimirov
force-pushed
the
vladimirov/persist-package-json-indent
branch
from
28e70de to
e511b67
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case project's package.json uses tabs or multiple spaces for indentation, the postinstall script of nativescript-dev-webpack overwrites it with two spaces whenever it is executed.
The problem is that the plugin tries to modify the package.json and persists it on every operation.
Fix the behavior by checking the indentation character and use it when stringifying the content.
Also compare the current content of the file with the one we will write and skip the write operation in case they match.
Add unit tests for the new methods.
PR Checklist
What is the current behavior?
When the project's package.json is indented with tabs or more than two spaces, running the postinstall script of the plugin overwrites the content with indentation with two spaces.
What is the new behavior?
Indentation is persisted. Also package.json will not be overwritten in case there's no need.
Fixes issue NativeScript/nativescript-cli#4190