Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat(scripts): add ns-bundle and verify-bundle #69

Merged
merged 3 commits into from
Feb 8, 2017
Merged

feat(scripts): add ns-bundle and verify-bundle #69

merged 3 commits into from
Feb 8, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Feb 8, 2017

No description provided.

sis0k0 added 2 commits February 3, 2017 14:47
@sis0k0
fix: run tns-xml-loader before @ngtools loader
f073eda 
This is needed due to changes in the behaviour of `@ngtools/webpack` v1.2.4

fixes #64
@sis0k0
feat(scripts): add ns-bundle and verify-bundle
7ea5592
hdeshev
hdeshev suggested changes Feb 8, 2017
View reviewed changes
Copy link
Contributor

@hdeshev hdeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we rename verify-bundle to ns-verify-bundle.

We also need to change the installer, so that it registers app package.json scripts that call ns-bundle.

hdeshev
hdeshev approved these changes Feb 8, 2017
View reviewed changes
Copy link
Contributor

@hdeshev hdeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash ns-bundle commits before merging, please.

@sis0k0 sis0k0 merged commit e80cbdc into master Feb 8, 2017
@sis0k0 sis0k0 deleted the vlaeva/bundle-scripts branch February 8, 2017 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hdeshev hdeshev hdeshev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sis0k0 @hdeshev