This repository was archived by the owner on Aug 7, 2021. It is now read-only.
ExcludeUnusedElements plugin + loader added #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdeshev
suggested changes
Dec 22, 2016
| @@ -19,5 +19,6 @@ | |||
| "dependencies": { | |||
| }, | |||
| "devDependencies": { | |||
| "htmlparser2": "^3.9.2" | |||
There was a problem hiding this comment.
htmlparser2 must be installed by the postinstall script. Without that we get runtime errors on user machines since the module is required by our plugin.
| // | ||
| } | ||
|
|
||
| exports.ExcludeUnusedElements.prototype = { |
There was a problem hiding this comment.
I suggest we rename this to ExcludeUnusedElementsPlugin. Other plugins use the same suffix.
| } | ||
|
|
||
| exports.ExcludeUnusedElements.prototype = { | ||
| apply: function (compiler) { |
There was a problem hiding this comment.
Why not just exports.ExcludeUnusedElementsPlugin.prototype.apply = function... ?
|
|
||
| if (result.context.indexOf("tns-core-modules") === -1) { | ||
| if (result.contextInfo.issuer && | ||
| result.contextInfo.issuer.indexOf("element-registry") !== -1 && global["ELEMENT_REGISTRY"][result.request] && |
There was a problem hiding this comment.
global["ELEMENT_REGISTRY"][result.request] && !global["ELEMENT_REGISTRY"][result.request]
I think we need just !global["ELEMENT_REGISTRY"][result.request]
| } | ||
| } | ||
|
|
||
| if (result.contextInfo.issuer.indexOf("bundle-entry-points") !== -1 && global["ELEMENT_REGISTRY"][result.request] && |
There was a problem hiding this comment.
Again, I think we need just !global["ELEMENT_REGISTRY"][result.request]
enchev
force-pushed
the
ExcludeUnusedElements
branch
2 times, most recently
from
bfaef4c to
aa84f58
Compare
enchev
force-pushed
the
ExcludeUnusedElements
branch
from
aa84f58 to
7b5e9ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.