refactor: remove tns-core-modules/xml dependency #1047

vakrilov · 2019-09-17T08:29:31Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

xml-namespace-loader depends on tns-core-modules/xml.

xml-namespace-loader now uses sax.

Related to #932

vakrilov · 2019-09-17T13:17:54Z

test

vakrilov · 2019-09-20T10:31:44Z

test

cla-bot bot added the cla: yes label Sep 17, 2019

vakrilov requested a review from rosen-vladimirov September 17, 2019 10:51

vakrilov closed this Sep 17, 2019

vakrilov reopened this Sep 17, 2019

vakrilov requested a review from DimitarTachev September 17, 2019 13:41

vakrilov changed the title ~~Remove tns xml~~ chore: remove tns-core-modules/xml dependency Sep 19, 2019

vakrilov changed the title ~~chore: remove tns-core-modules/xml dependency~~ refactor: remove tns-core-modules/xml dependency Sep 19, 2019

vakrilov added 5 commits September 19, 2019 15:48

test: add xml-namespace-loader tests

22370c4

chore: convert xml-ns-loader to TS

3a201fa

refactor: remove duplicate registers

bfd7d1d

refactor: use sax xml parser instead of tns

56e85dd

chore: clean useless value set (causes strict err)

69359fe

vakrilov force-pushed the remove-tns-xml branch from 5476bd5 to 69359fe Compare September 19, 2019 12:48

text: fix tests for Windows

7e43180

DimitarTachev approved these changes Sep 24, 2019

View reviewed changes

vakrilov merged commit 45e2411 into master Sep 24, 2019

vakrilov deleted the remove-tns-xml branch September 24, 2019 13:07

vakrilov added the ready for test label Sep 24, 2019