This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: auto accept new or deleted files #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Newly created or deleted files cause changes in
./ sync recursive ( ....)$module (created by therequire.contextadded bu bundle-config-loader). These changes cause app restart as they are not handled by HMR.What is the new behavior?
Added
hot.accept()for the./ sync recursive ( ....)$module just after it is added in the app-entry point (app.ts/js). This will accept hot-updates for it when files are added/deleted/renamed.Note: If the modified files are required somewhere in the app they will still be handled by the regular HMR handling.