fix: resolve appComponents and xml namespaces absolute paths on Windows #578

vchimev · 2018-06-21T21:56:57Z

Fixes #573.

sis0k0 · 2018-06-22T14:18:58Z

android-app-components-loader.js

    this.cacheable();
    const { modules } = this.query;
-    const imports = modules.map(m => `require("${m}");`).join("\n");
+    const imports = modules.map(m => convertSlashesInPath(m))


.map(m => convertSlashesInPath(m)) can be simplified to .map(convertSlashesInPath)

sis0k0 · 2018-06-22T14:19:31Z

demo/AngularApp/references.d.ts

@@ -0,0 +1,2 @@
+/// <reference path="./node_modules/tns-platform-declarations/ios.d.ts" />


Why is this needed?

Because of native API - otherwise, transpilation fails.

cast to any? I mean, it's a test app.

sis0k0 · 2018-06-22T14:20:08Z

demo/JavaScriptApp/app/activity.android.js

@@ -0,0 +1,35 @@
+let frame = require("ui/frame");


sis0k0 · 2018-06-22T14:20:19Z

demo/JavaScriptApp/app/activity.android.js

@@ -0,0 +1,35 @@
+let frame = require("ui/frame");
+
+let superProto = android.app.Activity.prototype;


sis0k0 · 2018-06-22T14:20:52Z

demo/JavaScriptApp/app/activity.android.js

+let frame = require("ui/frame");
+
+let superProto = android.app.Activity.prototype;
+let Activity = android.app.Activity.extend("org.myApp.MainActivity", {


const. Maybe it's not even needed to assign this to a variable.

sis0k0 · 2018-06-22T14:21:01Z

demo/JavaScriptApp/app/application.android.js

@@ -0,0 +1,16 @@
+var superProto = android.app.Application.prototype;


sis0k0 · 2018-06-22T14:21:14Z

demo/JavaScriptApp/app/application.android.js

@@ -0,0 +1,16 @@
+var superProto = android.app.Application.prototype;
+// the first parameter of the `extend` call defines the package and the name for the native *.JAVA file generated. 
+var Application = android.app.Application.extend("org.myApp.Application", {


same comment as for the activity

sis0k0 · 2018-06-22T14:22:13Z

demo/TypeScriptApp/app/application.android.ts

@@ -0,0 +1,18 @@
+// the `JavaProxy` decorator specifies the package and the name for the native *.JAVA file generated.


Remove the comments.

sis0k0 · 2018-06-22T14:25:40Z

xml-namespace-loader.js

@@ -67,6 +68,11 @@ module.exports = function(source) {
    parser.parse(source);

    const moduleRegisters = namespaces
+        .map(function (n) {
+            let obj = n;


This variable is not needed. Also extract that function.

Fix #573.

Clean up npm scripts.

The nativescript-dev-appium plugin gets it automatically, no need to declare it in the `appium.capabilities.json` file.

RoyiNamir · 2018-07-02T12:48:50Z

@sis0k0 @vchimev
Hi.How can we know to which version is it merged to ?
I mean - say I want to use this merged fix - what should I install ? which version ?

sis0k0 · 2018-07-02T14:25:29Z

Hi, @RoyiNamir! For this plugin, usually the best place is the changelog.

RoyiNamir · 2018-07-02T14:27:47Z

@sis0k0 Hey :) Thanks for the info 👍 . (So I guess there's still a problem) after the merge .

sis0k0 · 2018-07-02T14:37:27Z

No problem :) We'll investigate the issue you opened.

vchimev force-pushed the vchimev/component-resolve-windows branch from 78305d6 to adb67b4 Compare June 21, 2018 21:59

vchimev requested a review from sis0k0 June 21, 2018 22:00

vchimev self-assigned this Jun 21, 2018

vchimev requested a review from manoldonev June 22, 2018 05:52

vchimev force-pushed the vchimev/component-resolve-windows branch 2 times, most recently from 2d06055 to ba89c28 Compare June 22, 2018 13:39

sis0k0 suggested changes Jun 22, 2018

View reviewed changes

This was referenced Jun 23, 2018

Snapshot Bundle failed with custom android activity #568

Closed

Nativescript 4.1.0 using custom main activity with webpack #559

Closed

uglify option prevent the generation of application java class. #564

Closed

vchimev force-pushed the vchimev/component-resolve-windows branch 2 times, most recently from d84ce1b to 92415df Compare June 25, 2018 11:01

sis0k0 approved these changes Jun 25, 2018

View reviewed changes

vchimev and others added 17 commits June 25, 2018 22:10

fix: resolve appComponents absolute paths on Windows

ae1cceb

Fix #573.

fix: resolve xml namespaces absolute paths on Windows

6e77f4b

chore(JavaScriptApp): add webpack.config.js file

35112fc

Clean up npm scripts.

test(JavaScriptApp): extend android application

b22ba3b

test(JavaScriptApp): extend android activity

1677aac

chore(TypeScriptApp): add webpack.config.js file

b42f16a

Clean up npm scripts.

chore(TypeScriptApp): add platform declarations

0ed2c5a

test(TypeScriptApp): extend android application

e9a1ea7

test(TypeScriptApp): extend android activity

cdde491

chore(AngularApp): add webpack.config.js file

24ff369

Clean up npm scripts.

chore(AngularApp): add platform declarations

8c196ff

test(AngularApp): extend android application

b271bbb

test(AngularApp): extend android activity

ac6295c

chore(AngularApp): update @angular/compiler-cli version

b31b5f0

refactor(demos): minor tweaks

dc38afc

chore(JavaScript): remove unused variables

f8aa3a9

refactor: address comments

6a8fdad

vchimev added 3 commits June 25, 2018 22:10

chore(e2e): update application activity to launch

25de3d4

refactor: remove tns-platform-declarations dependency

b8cd317

chore(e2e): remove application activity from capabilities

bbb9716

The nativescript-dev-appium plugin gets it automatically, no need to declare it in the `appium.capabilities.json` file.

vchimev force-pushed the vchimev/component-resolve-windows branch from aef8202 to bbb9716 Compare June 25, 2018 19:10

vchimev merged commit 14de7e1 into master Jun 26, 2018

RoyiNamir mentioned this pull request Jul 2, 2018

Absolute path is not resolved in v0.14.2 when extending activity #592

Closed

RoyiNamir mentioned this pull request Jul 3, 2018

Latest version problem with --bundle ddfreiling/tns-ng-deeplink#4

Closed

vchimev deleted the vchimev/component-resolve-windows branch December 17, 2018 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

vchimev commented Jun 21, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

vchimev Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

sis0k0 Jun 22, 2018

RoyiNamir commented Jul 2, 2018

sis0k0 commented Jul 2, 2018

RoyiNamir commented Jul 2, 2018 •

edited

Loading

sis0k0 commented Jul 2, 2018

		@@ -0,0 +1,2 @@
		/// <reference path="./node_modules/tns-platform-declarations/ios.d.ts" />

		@@ -0,0 +1,35 @@
		let frame = require("ui/frame");

		let superProto = android.app.Activity.prototype;

		@@ -0,0 +1,16 @@
		var superProto = android.app.Application.prototype;

		@@ -0,0 +1,18 @@
		// the `JavaProxy` decorator specifies the package and the name for the native *.JAVA file generated.

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

fix: resolve appComponents and xml namespaces absolute paths on Windows #578

Conversation

vchimev commented Jun 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RoyiNamir commented Jul 2, 2018

sis0k0 commented Jul 2, 2018

RoyiNamir commented Jul 2, 2018 • edited Loading

sis0k0 commented Jul 2, 2018

RoyiNamir commented Jul 2, 2018 •

edited

Loading