Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Angular 5 Support #311

Closed
2 of 4 tasks
sis0k0 opened this issue Nov 3, 2017 · 1 comment
Closed
2 of 4 tasks

Angular 5 Support #311

sis0k0 opened this issue Nov 3, 2017 · 1 comment

Comments

@sis0k0
Copy link
Contributor

sis0k0 commented Nov 3, 2017

  • Switch to use AngularCompilerPlugin instead of AotPlugin.
    For Angular 5 support, the new AngularCompilerPlugin should be used instead of the AotPlugin.
    This will depend on the @next tags of nativescript-angular which target Angular 5. Angular 5 Support: Switch to use AngularCompilerPlugin  #312

  • Remove UrlResolvePlugin
    UrlResolvePlugin should be removed as it uses the AotPlugin and tries to fetch _program (TS compilation) on the make life-cycle event of the webpack compilation. With the AngularCompilerPlugin, _program is not available on that step of the compilation.
    We can augment the input files system. However, there are problems with the AngularCompilerPlugin, which replaces the InputFileSystem code. CSS loader parsing CSS to JSON, platform suffix resolver and platform file system plugins #290

  • When compiling NativeScript Angular with ngc v5, metadata for polyfills gets generated too. However, these files doesn't contain decorators and Angular components/modules, and the metadata files contain only [null]. This causes the AngularCompiler Plugin to fail with the following error: https://gist.github.com/sis0k0/5f36e8f6e4177380e4fd55d500118663
    We can publish the metadata inside the npm package for nativescript-angular and manually remove the generated files for the polyfills.

  • If you use npm linked packages that have both .js and .ts files, webpack will prefer the .ts file and try to compile it with ngc. The compilation fails for nativescript-angular with NativeScriptModule is not an NgModule type of error.

@sis0k0
Copy link
Contributor Author

sis0k0 commented Dec 20, 2017

Released with 0.9.0.

@sis0k0 sis0k0 closed this as completed Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant