Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Publish a __extends scrubbing loader #14

Open
hdeshev opened this issue Jul 28, 2016 · 3 comments
Open

Publish a __extends scrubbing loader #14

hdeshev opened this issue Jul 28, 2016 · 3 comments
Labels

Comments

@hdeshev
Copy link
Contributor

hdeshev commented Jul 28, 2016

Originally reported in #8. Not passing the noEmitHelpers TypeScript compiler option generates multiple __extends functions which supersede the "runtime" __extends implementation when bundled.

Ideally third party plugins should compile with noEmitHelpers enabled, but the reality is that many of them don't do so. @NathanaelA has created a webpack loader that strips the module-local __extends code, so that apps work without modifying third party plugins. If given permission, we should publish and document this loader.

@NathanaelA
Copy link

@hdeshev feel free to steal the code and use it; having it an integrated whole is a much better solution than trying to get people to manually install it. :-)

@ghost
Copy link

ghost commented Feb 8, 2017

@hdeshev No crashing with 2.5 and @latest plugin, was this patched in somehow?

@lambourn
Copy link

lambourn commented Mar 8, 2018

just encountered the crash for an iOS build so I believe it's still in.

In my case it was not 3rd party plugin code that caused this but some code with platform specific implementations in the main ./app folder (i.e. something.ios.ts).

Specifically, the implementation was extending UIView and thus the __extends got emitted.

@sis0k0 sis0k0 added the backlog label Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants