Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix(ns-bundle): use remove/add platform instead of clean-app #116

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Apr 13, 2017

Leaving old build files in the platform folders caused several issues.

fixes #75, fixes #112

Leaving old build files in the platform folders caused several issues.

fixes 75, fixes 112
@vchimev vchimev closed this Apr 13, 2017
@vchimev vchimev reopened this Apr 13, 2017
@vchimev
Copy link
Contributor

vchimev commented Apr 13, 2017

run ci

1 similar comment
@sis0k0
Copy link
Contributor Author

sis0k0 commented Apr 13, 2017

run ci

@ishitatsuyuki
Copy link

Is there any plans to make this unnecessary? Writing the platform again and again hurts my SSD (and it takes time for sure).

@sis0k0
Copy link
Contributor Author

sis0k0 commented May 5, 2017

Yep, we'll be looking for a workaround. Just wondering, how often are you bundling your project with webpack? We assume, people do this only for release builds (since it has no livereload yet), but I'm curious if you're using it for development.

@ishitatsuyuki
Copy link

Two cases:

  1. You don't want to destroy your SSD while investigating webpack config errors.
  2. Cache is ruined when doing both test and release build in CI.

Also, if I'm correct, this doesn't clean the things up after bundling right? It's probably causing a gradlew binding error then, starting from 3.0.

@ishitatsuyuki
Copy link

I have opened #145 to track this case. Let's discuss there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants