refactor: ignore compilation contexts from CLI watcher

Author: sis0k0

lib/before-watchPatterns.js

@@ -1,16 +1,33 @@
-const { AppDirectoryLocation } = require("./constants");
+const { basename } = require("path");
+const { buildEnvData, getCompilationContext } = require("./utils");
 
 module.exports = function (hookArgs) {
-	if (hookArgs.liveSyncData && hookArgs.liveSyncData.bundle) {
-		return (args, originalMethod) => {
-			return originalMethod(...args).then(originalPatterns => {
-				const appDirectoryLocationIndex = originalPatterns.indexOf(AppDirectoryLocation);
-				if (appDirectoryLocationIndex !== -1) {
-					originalPatterns.splice(appDirectoryLocationIndex, 1);
-				}
+    const { liveSyncData } = hookArgs;
+    if (!liveSyncData || !liveSyncData.bundle) {
+        return;
+    }
 
-				return originalPatterns;
-			});
-		};
-	}
+    const { platforms } = hookArgs;
+    const { env } = liveSyncData;
+    return (args, originalMethod) => {
+        return originalMethod(...args).then(originalPatterns => {
+            if (!platforms.length) {
+                throw new Error("Target platform should be specified!");
+            }
+
+            const compilationContexts = platforms.map(platform =>
+                getContext(platform, env));
+
+            const ignorePatterns = compilationContexts.map(
+                context => `!${context}`
+            );
+
+            return [...originalPatterns, ...ignorePatterns];
+        });
+    };
+}
+
+function getContext(platform, env) {
+    const fullEnvData = buildEnvData(platform, env);
+    return getCompilationContext(fullEnvData);
 }

lib/compiler.js

@@ -4,6 +4,7 @@ const { join, resolve: pathResolve } = require("path");
 const { existsSync } = require("fs");
 const readline = require("readline");
 const { messages } = require("../plugins/WatchStateLoggerPlugin");
+const { buildEnvData } = require("./utils");
 const { AppDirectoryLocation } = require("./constants");
 
 let hasBeenInvoked = false;
@@ -41,7 +42,9 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $mobileHelper,
             }
 
             console.log(`Running webpack for ${config.platform}...`);
-            const envFlagNames = Object.keys(config.env).concat([config.platform.toLowerCase()]);
+
+            const envData = buildEnvData(config.platform, config.env);
+            const envFlagNames = Object.keys(envData);
 
             const snapshotEnvIndex = envFlagNames.indexOf("snapshot");
             if (snapshotEnvIndex !== -1 && !utils.shouldSnapshot($mobileHelper, config)) {

lib/utils.js

@@ -2,22 +2,30 @@ const os = require("os");
 
 const { getProjectDir, getWebpackConfig } = require("../projectHelpers");
 
-function shouldSnapshot($mobileHelper, config) {
-    const platformSupportsSnapshot = $mobileHelper.isAndroidPlatform(config.platform);
-    const osSupportsSnapshot = os.type() !== "Windows_NT";
-
-    return config.bundle && config.release && platformSupportsSnapshot && osSupportsSnapshot;
+function buildEnvData(platform, env) {
+    return {
+        ...env,
+        [platform.toLowerCase()]: true,
+    };
 }
 
-function getCompilationContext() {
+function getCompilationContext(env) {
     const projectDir = getProjectDir();
-    const config = getWebpackConfig(projectDir);
+    const config = getWebpackConfig(projectDir, env);
     const context = config.context || projectDir;
 
     return context;
 }
 
+function shouldSnapshot($mobileHelper, config) {
+    const platformSupportsSnapshot = $mobileHelper.isAndroidPlatform(config.platform);
+    const osSupportsSnapshot = os.type() !== "Windows_NT";
+
+    return config.bundle && config.release && platformSupportsSnapshot && osSupportsSnapshot;
+}
+
 module.exports = {
-    shouldSnapshot,
+    buildEnvData,
     getCompilationContext,
+    shouldSnapshot,
 };