Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit dd7ba71

Browse files
authored
refactor: generate source maps when running tns debug --bundle (#617)
1 parent b509bb3 commit dd7ba71

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

lib/before-prepareJS.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const { runWebpackCompiler } = require("./compiler");
22

3-
module.exports = function ($logger, hookArgs) {
3+
module.exports = function ($logger, $liveSyncService, hookArgs) {
44
const env = hookArgs.config.env || {};
55
const platform = hookArgs.config.platform;
66
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
@@ -11,6 +11,6 @@ module.exports = function ($logger, hookArgs) {
1111
release: appFilesUpdaterOptions.release,
1212
};
1313

14-
const result = config.bundle && runWebpackCompiler.bind(runWebpackCompiler, config, hookArgs.config.projectData, $logger, hookArgs);
14+
const result = config.bundle && runWebpackCompiler.bind(runWebpackCompiler, config, hookArgs.config.projectData, $logger, $liveSyncService, hookArgs);
1515
return result;
1616
}

lib/before-watch.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const { runWebpackCompiler } = require("./compiler");
22

3-
module.exports = function ($logger, hookArgs) {
3+
module.exports = function ($logger, $liveSyncService, hookArgs) {
44
if (hookArgs.config) {
55
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
66
if (appFilesUpdaterOptions.bundle) {
@@ -15,7 +15,7 @@ module.exports = function ($logger, hookArgs) {
1515
watch: true
1616
};
1717

18-
return runWebpackCompiler(config, hookArgs.projectData, $logger, hookArgs);
18+
return runWebpackCompiler(config, hookArgs.projectData, $logger, $liveSyncService, hookArgs);
1919
}));
2020
}
2121
}

lib/compiler.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const { existsSync } = require("fs");
55
const readline = require("readline");
66

77
const { messages } = require("../plugins/WatchStateLoggerPlugin");
8-
const { buildEnvData } = require("./utils");
8+
const { buildEnvData, debuggingEnabled } = require("./utils");
99

1010
let hasBeenInvoked = false;
1111

@@ -16,7 +16,7 @@ exports.getWebpackProcess = function getWebpackProcess() {
1616
return webpackProcess;
1717
}
1818

19-
exports.runWebpackCompiler = function runWebpackCompiler(config, $projectData, $logger, hookArgs) {
19+
exports.runWebpackCompiler = function runWebpackCompiler(config, $projectData, $logger, $liveSyncService, hookArgs) {
2020
if (config.bundle) {
2121
return new Promise(function (resolveBase, rejectBase) {
2222
if (webpackProcess) {
@@ -39,6 +39,10 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $projectData, $
3939

4040
const projectDir = $projectData.projectDir;
4141
const { platform, env } = config;
42+
if (debuggingEnabled($liveSyncService, projectDir)) {
43+
env["sourceMap"] = true;
44+
}
45+
4246
const envData = buildEnvData($projectData, platform, env);
4347
const envParams = buildEnvCommandLineParams(config, envData, $logger);
4448

lib/utils.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ const {
88
isAndroid,
99
} = require("../projectHelpers");
1010

11+
function debuggingEnabled(liveSyncService, projectDir) {
12+
const deviceDescriptors = liveSyncService.getLiveSyncDeviceDescriptors(projectDir);
13+
return deviceDescriptors.some(device => device.debugggingEnabled);
14+
}
15+
1116
function buildEnvData($projectData, platform, env) {
1217
const envData = Object.assign({},
1318
env,
@@ -33,5 +38,6 @@ function shouldSnapshot(config) {
3338

3439
module.exports = {
3540
buildEnvData,
41+
debuggingEnabled,
3642
shouldSnapshot
3743
};

0 commit comments

Comments
 (0)