refactor(livesync): extract app as constant

Author: Dimitar Kerezov

Diff for: lib/before-prepareJS.js

@@ -7,8 +7,7 @@ module.exports = function ($mobileHelper, $projectData, hookArgs) {
 	const config = {
 		env,
 		platform,
-		bundle: appFilesUpdaterOptions.bundle,
-		watch: false
+		bundle: appFilesUpdaterOptions.bundle
 	};
 	const result = config.bundle && runWebpackCompiler.bind(runWebpackCompiler, config, $mobileHelper, $projectData, hookArgs);
 	return result;

Diff for: lib/before-watchPatterns.js

@@ -1,18 +1,14 @@
+const { AppDirectoryLocation } = require("./constants");
+
 module.exports = function (hookArgs) {
 	if (hookArgs.liveSyncData && hookArgs.liveSyncData.bundle) {
-		const appDirectoryLocation = "app"; // Might need to get this from config file in the future
-		const appResourcesDirectoryLocation = "app/App_Resources"; // Might need to get this from config file in the future
 		return (args, originalMethod) => {
 			return originalMethod().then(originalPatterns => {
-				const appDirectoryLocationIndex = originalPatterns.indexOf(appDirectoryLocation);
+				const appDirectoryLocationIndex = originalPatterns.indexOf(AppDirectoryLocation);
 				if (appDirectoryLocationIndex !== -1) {
 					originalPatterns.splice(appDirectoryLocationIndex, 1);
 				}
 
-				if (originalPatterns.indexOf(appResourcesDirectoryLocation) === -1) {
-					originalPatterns.push(appResourcesDirectoryLocation);
-				}
-
 				return originalPatterns;
 			});
 		};

Diff for: lib/compiler.js

@@ -4,7 +4,7 @@ const { join, resolve: pathResolve } = require("path");
 const { existsSync } = require("fs");
 const readline = require("readline");
 const { messages } = require("../plugins/WatchStateLoggerPlugin");
-const ProjectSnapshotGenerator = require("../snapshot/android/project-snapshot-generator");
+const { AppDirectoryLocation } = require("./constants");
 
 let hasBeenInvoked = false;
 
@@ -88,8 +88,7 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $mobileHelper,
                     }
 
                     if (hookArgs.filesToSync && hookArgs.startSyncFilesTimeout) {
-                        // TODO: Might need to get the "app" constant from config file in the future
-                        hookArgs.filesToSync.push(...message.emittedFiles.map(emittedFile => join("app", emittedFile)));
+                        hookArgs.filesToSync.push(...message.emittedFiles.map(emittedFile => join(AppDirectoryLocation, emittedFile)));
                         hookArgs.startSyncFilesTimeout();
                     }
                 }

Diff for: lib/constants.js

@@ -0,0 +1,3 @@
+module.exports = {
+	AppDirectoryLocation: "app"
+};