refactor: remove tns-xml-loader and ExcludeUnusedElementsPlugin (#90)

Migration: remove the loader and plugin from your webpack config

closes #79, #88

Author: sis0k0

Diff for: index.js

@@ -40,41 +40,6 @@ exports.NativeScriptJsonpPlugin.prototype.apply = function (compiler) {
     });
 };
 
-exports.ExcludeUnusedElementsPlugin = function () {
-};
-
-exports.ExcludeUnusedElementsPlugin.prototype.apply = function (compiler) {
-    compiler.plugin("normal-module-factory", function (nmf) {
-        nmf.plugin("before-resolve", function (result, callback) {
-            if (!result) {
-                return callback();
-            }
-
-            if (result.request === "globals" || result.request === "ui/core/view") {
-                return callback(null, result);
-            }
-
-            if (result.context.indexOf("tns-core-modules") === -1) {
-                if (result.contextInfo.issuer &&
-                    result.contextInfo.issuer.indexOf("element-registry") !== -1 && global.ELEMENT_REGISTRY &&
-                    !global.ELEMENT_REGISTRY[result.request]) {
-                    return callback();
-
-                } else {
-                    return callback(null, result);
-                }
-            }
-
-            if (result.contextInfo.issuer.indexOf("bundle-entry-points") !== -1 && global.ELEMENT_REGISTRY &&
-                !global.ELEMENT_REGISTRY[result.request]) {
-                return callback();
-            }
-
-            return callback(null, result);
-        });
-    });
-};
-
 exports.GenerateBundleStarterPlugin = function (bundles) {
     this.bundles = bundles;
 };

Diff for: installer.js

@@ -133,7 +133,6 @@ function getProjectDependencies() {
         dependencies["@angular/compiler-cli"] = "~2.4.3";
         dependencies["@ngtools/webpack"] = "1.2.10";
         dependencies["typescript"] = "^2.0.10";
-        dependencies["htmlparser2"] = "~3.9.2";
     } else {
         dependencies["awesome-typescript-loader"] = "~3.0.0-beta.9";
     }

Diff for: tns-xml-loader.js

@@ -44,10 +44,6 @@ module.exports = function (platform, destinationApp) {
             "./bundle",
         ]),
 
-        // Exclude explicitly required but never declared in XML elements. 
-        // Loader nativescript-dev-webpack/tns-xml-loader should be added for *.xml/html and *.ts files.
-        new nsWebpack.ExcludeUnusedElementsPlugin(),
-
         //Angular AOT compiler
         new AotPlugin({
             tsConfigPath: "tsconfig.aot.json",
@@ -112,7 +108,6 @@ module.exports = function (platform, destinationApp) {
                     test: /\.html$|\.xml$/,
                     loaders: [
                         "raw-loader",
-                        "nativescript-dev-webpack/tns-xml-loader",
                     ]
                 },
                 // Root app.css file gets extracted with bundled dependencies
@@ -138,7 +133,6 @@ module.exports = function (platform, destinationApp) {
                     loaders: [
                         "nativescript-dev-webpack/tns-aot-loader",
                         "@ngtools/webpack",
-                        "nativescript-dev-webpack/tns-xml-loader",
                     ]
                 },
                 // SASS support