Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 8e1a5a6

Browse files
authored
fix(css): disable minification when using uglify (#383)
* fix(css): disable minification when using uglify related to #154, #135 fixes #377 * refactor: inline css-loader options
1 parent 8a20502 commit 8e1a5a6

File tree

3 files changed

+38
-6
lines changed

3 files changed

+38
-6
lines changed

Diff for: templates/webpack.angular.js

+14-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,20 @@ module.exports = env => {
6060
{ test: /\.html$|\.xml$/, use: "raw-loader" },
6161

6262
// tns-core-modules reads the app.css and its imports using css-loader
63-
{ test: /[\/|\\]app\.css$/, use: "css-loader?url=false" },
64-
{ test: /[\/|\\]app\.scss$/, use: ["css-loader?url=false", "sass-loader"] },
63+
{
64+
test: /[\/|\\]app\.css$/,
65+
use: {
66+
loader: "css-loader",
67+
options: { minimize: false, url: false },
68+
}
69+
},
70+
{
71+
test: /[\/|\\]app\.scss$/,
72+
use: [
73+
{ loader: "css-loader", options: { minimize: false, url: false } },
74+
"sass-loader"
75+
]
76+
},
6577

6678
// Angular components reference css files and their imports using raw-loader
6779
{ test: /\.css$/, exclude: /[\/|\\]app\.css$/, use: "raw-loader" },

Diff for: templates/webpack.javascript.js

+12-2
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,18 @@ module.exports = env => {
5757
rules: [
5858
{ test: /\.(html|xml)$/, use: "raw-loader" },
5959

60-
{ test: /\.css$/, use: "css-loader?url=false" },
61-
{ test: /\.scss$/, use: ["css-loader?url=false", "sass-loader"] },
60+
{
61+
test: /\.css$/,
62+
use: { loader: "css-loader", options: { minimize: false, url: false } }
63+
},
64+
65+
{
66+
test: /\.scss$/,
67+
use: [
68+
{ loader: "css-loader", options: { minimize: false, url: false } },
69+
"sass-loader"
70+
]
71+
}
6272
]
6373
},
6474
plugins: [

Diff for: templates/webpack.typescript.js

+12-2
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,18 @@ module.exports = env => {
5757
rules: [
5858
{ test: /\.(html|xml)$/, use: "raw-loader" },
5959

60-
{ test: /\.css$/, use: "css-loader?url=false" },
61-
{ test: /\.scss$/, use: ["css-loader?url=false", "sass-loader"] },
60+
{
61+
test: /\.css$/,
62+
use: { loader: "css-loader", options: { minimize: false, url: false } }
63+
},
64+
65+
{
66+
test: /\.scss$/,
67+
use: [
68+
{ loader: "css-loader", options: { minimize: false, url: false } },
69+
"sass-loader"
70+
]
71+
},
6272

6373
{ test: /\.ts$/, use: "awesome-typescript-loader" }
6474
]

0 commit comments

Comments
 (0)