Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 6a9268c

Browse files
Vladimirov/fix lazy loading loader release (#778)
* fix(Vue): apply style changes with HMR (#763) * fix(Vue): apply style changes with HMR The `bundle-config-loader` executes for `entryPath` with all extensions: `css`, `js`, `ts`, `scss`, etc. Limit only to `js` and `ts`. Fixes #762. * Revert "fix(Vue): resolve full path for entry module (#744)" This reverts commit 4d31ea0. It causes #762. * fix(Vue): entry module path Fixes #742, fixes #762. * Release 0.19.0 (#757) * fix: lazy-ngmodule-hot-loader breaks the sourceMaps The `lazy-ngmodule-hot-loader` breaks sourceMaps as it does not pass them to the next loaders. This breaks debugging with `--bundle` in VSCode extension as the files included in the `sourcesContent` cannot be mapped correctly to local files.
1 parent 8ee1880 commit 6a9268c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: CHANGELOG.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,17 @@
11
<a name="0.19.0"></a>
2-
# [0.19.0](https://github.com/NativeScript/nativescript-dev-webpack/compare/0.18.3...0.19.0) (2019-01-03)
2+
# [0.19.0](https://github.com/NativeScript/nativescript-dev-webpack/compare/0.18.5...0.19.0) (2019-01-03)
33

44

55
### Bug Fixes
66

77
* **angular:** support angular lazy routes in preview ([#753](https://github.com/NativeScript/nativescript-dev-webpack/issues/753)) ([a6c23da](https://github.com/NativeScript/nativescript-dev-webpack/commit/a6c23da))
88
* **Angular:** add hot loader for lazy loaded NgModules ([#747](https://github.com/NativeScript/nativescript-dev-webpack/issues/747)) ([6a9db32](https://github.com/NativeScript/nativescript-dev-webpack/commit/6a9db32))
9-
* **JS/TS:** use webpack resolver instead of Node.js resolver ([#681](https://github.com/NativeScript/nativescript-dev-webpack/issues/681)) ([9adc7e7](https://github.com/NativeScript/nativescript-dev-webpack/commit/9adc7e7))
109
* **Vue:** disable mangling of function names when building in production mode ([#743](https://github.com/NativeScript/nativescript-dev-webpack/issues/743)) ([fffcf66](https://github.com/NativeScript/nativescript-dev-webpack/commit/fffcf66)), closes [/github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2](https://github.com//github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md/issues/testing-locally-by-running-e2)
1110

1211

1312
### Features
1413

1514
* **TypeScript:** use `ts-loader` instead of `awesome-typescript-loader` ([#738](https://github.com/NativeScript/nativescript-dev-webpack/issues/738)) ([7f67198](https://github.com/NativeScript/nativescript-dev-webpack/commit/7f67198))
16-
* **Vue:** add support for TypeScript ([#734](https://github.com/NativeScript/nativescript-dev-webpack/issues/734)) ([d290515](https://github.com/NativeScript/nativescript-dev-webpack/commit/d290515))
1715

1816

1917
### BREAKING CHANGES

Diff for: lazy-ngmodule-hot-loader.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ const isLazyLoadedNgModule = resource => {
1010
return issuerContext && issuerContext.endsWith(LAZY_RESOURCE_CONTEXT);
1111
};
1212

13-
module.exports = function (source) {
14-
return isLazyLoadedNgModule(this._module) ?
13+
module.exports = function (source, map) {
14+
const modifiedSource = isLazyLoadedNgModule(this._module) ?
1515
`${source};${HOT_SELF_ACCEPT}`:
1616
source;
17+
18+
this.callback(null, modifiedSource, map);
1719
};

0 commit comments

Comments
 (0)