fix: snapshot scope "frame" requires in vendor android

Author: sis0k0

projectFilesManager.js

@@ -1,7 +1,17 @@
 const path = require("path");
 const fs = require("fs");
 
-const helpers = require("./projectHelpers");
+const { isTypeScript, isAngular } = require("./projectHelpers");
+
+const FRAME_MATCH =  /(\s*)(require\("ui\/frame"\);)(\s*)(require\("ui\/frame\/activity"\);)/;
+const SCOPED_FRAME = `
+if (!global["__snapshot"]) {
+    // In case snapshot generation is enabled these modules will get into the bundle
+    // but will not be required/evaluated. 
+    // The snapshot webpack plugin will add them to the tns-java-classes.js bundle file.
+    // This way, they will be evaluated on app start as early as possible.
+    $1\t$2$3\t$4
+}`;
 
 function addProjectFiles(projectDir, appDir) {
     const projectTemplates = getProjectTemplates(projectDir);
@@ -51,10 +61,10 @@ function copyTemplate(templateName, destinationPath) {
 function getProjectTemplates(projectDir) {
     let templates = {}
 
-    if (helpers.isAngular({projectDir})) {
+    if (isAngular({projectDir})) {
         templates["webpack.angular.js"] = "webpack.config.js";
         templates["tsconfig.aot.json"] = "tsconfig.aot.json";
-    } else if (helpers.isTypeScript({projectDir})) {
+    } else if (isTypeScript({projectDir})) {
         templates["webpack.typescript.js"] = "webpack.config.js";
     } else {
         templates["webpack.javascript.js"] = "webpack.config.js";
@@ -69,7 +79,7 @@ function getAppTemplates(projectDir, appDir) {
         "vendor-platform.ios.ts": tsOrJs(projectDir, "vendor-platform.ios"),
     };
 
-    if (helpers.isAngular({projectDir})) {
+    if (isAngular({projectDir})) {
         templates["vendor.angular.ts"] = tsOrJs(projectDir, "vendor");
     } else {
         templates["vendor.nativescript.ts"] = tsOrJs(projectDir, "vendor");
@@ -95,15 +105,24 @@ function editExistingProjectFiles(projectDir) {
     const webpackConfigPath = getFullPath(projectDir, "webpack.config.js");
     const webpackCommonPath = getFullPath(projectDir, "webpack.common.js");
 
-    editWebpackConfig(webpackConfigPath, replaceStyleUrlResolvePlugin);
-    editWebpackConfig(webpackCommonPath, replaceStyleUrlResolvePlugin);
+    editFileContent(webpackConfigPath, replaceStyleUrlResolvePlugin);
+    editFileContent(webpackCommonPath, replaceStyleUrlResolvePlugin);
+
+    const extension = isAngular({projectDir}) ? "ts" : "js";
+    const vendorAndroidPath = getFullPath(
+        projectDir,
+        `app/vendor-platform.android.${extension}`
+    );
+
+    editFileContent(vendorAndroidPath, addSnapshotToVendor);
 }
 
-function editWebpackConfig(path, fn) {
+function editFileContent(path, fn) {
     if (!fs.existsSync(path)) {
         return;
     }
 
+    console.log('editing: ' + path)
     const config = fs.readFileSync(path, "utf8");
     const newConfig = fn(config);
 
@@ -114,12 +133,25 @@ function replaceStyleUrlResolvePlugin(config) {
     return config.replace(/StyleUrlResolvePlugin/g, "UrlResolvePlugin");
 }
 
+function addSnapshotPlugin(config) {
+
+}
+
+function addSnapshotToVendor(content) {
+    if (content.indexOf("__snapshot") > -1) {
+        return content;
+    }
+
+
+    return content.replace(FRAME_MATCH, SCOPED_FRAME);
+}
+
 function getFullPath(projectDir, filePath) {
     return path.resolve(projectDir, filePath);
 }
 
 function tsOrJs(projectDir, name) {
-    const extension = helpers.isTypeScript({projectDir}) ? "ts" : "js";
+    const extension = isTypeScript({projectDir}) ? "ts" : "js";
     return `${name}.${extension}`;
 }