Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 5a42e32

Browse files
author
Dimitar Kerezov
committed
Minor fix
Fix `cwd` parameter name. Remove `shell: true` becuase it causes issues on windows.
1 parent 3507346 commit 5a42e32

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

Diff for: bin/ns-bundle

+1-1
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ function spawnChildProcess(command, ...args) {
225225

226226
const childProcess = spawn(command, escapedArgs, {
227227
stdio: "inherit",
228-
pwd: PROJECT_DIR,
228+
cwd: PROJECT_DIR,
229229
shell: true,
230230
});
231231

Diff for: lib/compiler.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $mobileHelper,
7070
// These will notify us for the webpack compilation states.
7171
// Enables `childProcess.on("message", msg => ...)` kind of communication.
7272
stdio: config.watch ? ["inherit", "inherit", "inherit", "ipc"] : "inherit",
73-
pwd: $projectData.projectDir,
74-
shell: true,
73+
cwd: $projectData.projectDir
7574
});
7675

7776
function resolveOnWebpackCompilationComplete(message) {

Diff for: verify/update.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function execute(command) {
6969
return new Promise((resolve, reject) => {
7070
const args = command.split(" ");
7171
spawnChildProcess(...args)
72-
.then(resolve)
72+
.then(resolve)
7373
.catch(throwError)
7474
});
7575
}
@@ -80,7 +80,7 @@ function spawnChildProcess(command, ...args) {
8080

8181
const childProcess = spawn(command, escapedArgs, {
8282
stdio: "inherit",
83-
pwd: PROJECT_DIR,
83+
cwd: PROJECT_DIR,
8484
shell: true,
8585
});
8686

0 commit comments

Comments
 (0)