Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 4b704b2

Browse files
authored
revert: update script configuration (#302)
* Revert "refactor(update-ns-webpack): provide multiple options for updating the plugin (#297)" This reverts commit edf04f6. * Revert "chore: provide --force flag to update webpack configurations (#295)" This reverts commit 66d77c1.
1 parent edf04f6 commit 4b704b2

File tree

5 files changed

+19
-138
lines changed

5 files changed

+19
-138
lines changed

Diff for: bin/update-ns-webpack

+15-10
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
#!/usr/bin/env node
2+
const { resolve } = require("path");
23

3-
const update = require("../verify/update");
4+
const { getPackageJson, getProjectDir, writePackageJson } = require("../projectHelpers");
5+
const { forceUpdateProjectDeps } = require("../dependencyManager");
6+
const { editExistingProjectFiles } = require("../projectFilesManager");
47

5-
const flags = JSON.parse(process.env.npm_config_argv).original
6-
.filter(f => f.startsWith("--"))
7-
.map(f => f.substring(2));
8+
const PROJECT_DIR = getProjectDir({ nestingLvl: 2 });
9+
const packageJson = getPackageJson(PROJECT_DIR);
810

9-
function addOption(all, current) {
10-
all[current] = true;
11-
return all;
12-
}
13-
const options = flags.reduce(addOption, {});
11+
console.info("Updating dev dependencies...");
1412

15-
update(options);
13+
const { deps } = forceUpdateProjectDeps(packageJson);
14+
packageJson.devDependencies = deps;
15+
writePackageJson(packageJson, PROJECT_DIR);
16+
17+
console.info("\nUpdating configuration files...");
18+
editExistingProjectFiles(PROJECT_DIR);
19+
20+
console.info("\nProject successfully updated! Don't forget to run `npm install`");
1621

Diff for: installer.js

+3-6
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,9 @@ function uninstall() {
3232

3333
projectFilesManager.removeProjectFiles(PROJECT_DIR, APP_DIR);
3434

35-
const scripts = packageJson.scripts;
36-
if (scripts) {
37-
console.log("Removing npm scripts...");
38-
npmScriptsManager.removeDeprecatedNpmScripts(scripts);
39-
npmScriptsManager.removeNpmScripts(scripts);
40-
}
35+
console.log("Removing npm scripts...");
36+
npmScriptsManager.removeDeprecatedNpmScripts(packageJson);
37+
npmScriptsManager.removeNpmScripts(packageJson.scripts);
4138

4239
helpers.writePackageJson(packageJson, PROJECT_DIR);
4340

Diff for: npmScriptsManager.js

-8
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,8 @@ function removePlatformScripts(scripts, nameTemplate) {
5353
});
5454
}
5555

56-
function forceUpdateNpmScripts(scripts) {
57-
removeDeprecatedNpmScripts(scripts);
58-
removeNpmScripts(scripts);
59-
60-
addNpmScripts(scripts);
61-
}
62-
6356
module.exports = {
6457
addNpmScripts,
6558
removeDeprecatedNpmScripts,
6659
removeNpmScripts,
67-
forceUpdateNpmScripts,
6860
};

Diff for: projectFilesManager.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,10 @@ function removeProjectFiles(projectDir, appDir) {
5959
});
6060
}
6161

62-
function forceUpdateProjectFiles(projectDir, appDir) {
63-
removeProjectFiles(projectDir, appDir);
64-
addProjectFiles(projectDir, appDir);
65-
}
66-
6762
function deleteFile(destinationPath) {
6863
if (fs.existsSync(destinationPath)) {
6964
console.info(`Deleting file: ${destinationPath}`);
70-
fs.unlinkSync(destinationPath);
65+
fs.unlink(destinationPath);
7166
}
7267
}
7368

@@ -194,7 +189,5 @@ function tsOrJs(projectDir, name) {
194189
module.exports = {
195190
addProjectFiles,
196191
removeProjectFiles,
197-
forceUpdateProjectFiles,
198192
editExistingProjectFiles,
199193
};
200-

Diff for: verify/update.js

-106
This file was deleted.

0 commit comments

Comments
 (0)