fix: get project data safely

Author: sis0k0

Diff for: nsCliHelpers.js

@@ -7,7 +7,8 @@ const PROJECT_DATA_GETTERS = {
 
 function getProjectData(projectDir) {
     const cli = getNsCli();
-    const projectData = cli.projectDataService.getProjectData(projectDir);
+    const projectDataService = cli.projectDataService;
+    const projectData = safeGet(cli, "getProjectData", projectDir);
 
     return projectData;
 }
@@ -19,7 +20,23 @@ function getNsCli() {
     return cli;
 }
 
+function safeGet(object, property, args) {
+    if (!object) {
+        return;
+    }
+
+    const value = object[property];
+    if (!value) {
+        return;
+    }
+
+    return typeof value === "function" ?
+        value.bind(object)(...args) :
+        value;
+}
+
 module.exports = {
     PROJECT_DATA_GETTERS,
     getProjectData,
+    safeGet,
 };

Diff for: projectHelpers.js

@@ -3,7 +3,11 @@ const fs = require("fs");
 const semver = require("semver");
 const { EOL } = require("os");
 
-const { getProjectData, PROJECT_DATA_GETTERS } = require("./nsCliHelpers");
+const {
+    PROJECT_DATA_GETTERS,
+    getProjectData,
+    safeGet,
+} = require("./nsCliHelpers");
 
 const APP_DIR = "app";
 
@@ -163,21 +167,6 @@ function getAppResourcesPathFromProjectData(data) {
     return safeGet(data, PROJECT_DATA_GETTERS.appResourcesPath);
 }
 
-function safeGet(object, property) {
-    if (!object) {
-        return;
-    }
-
-    const value = object[property];
-    if (!value) {
-        return;
-    }
-
-    return typeof value === "function" ?
-        value.bind(object)() :
-        value;
-}
-
 module.exports = {
     getAppPath,
     getAppPathFromProjectData,
@@ -195,5 +184,4 @@ module.exports = {
     resolveAndroidAppPath,
     resolveAndroidConfigurationsPath,
     writePackageJson,
-    safeGet,
 };