Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 3591fc6

Browse files
committed
test: refactor to use NativeScriptCommonModule instead of
NativeScriptModule
1 parent fd52211 commit 3591fc6

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

Diff for: demo/AngularApp/app/ninjas/details/ninja.module.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from "@angular/core";
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33
import { NativeScriptRouterModule } from "nativescript-angular/router";
44

55
import { NinjaComponent } from "./ninja.component";
@@ -8,9 +8,9 @@ import { routes } from "./ninja.routes";
88
@NgModule({
99
schemas: [NO_ERRORS_SCHEMA],
1010
imports: [
11-
NativeScriptModule,
1211
NativeScriptRouterModule,
13-
NativeScriptRouterModule.forChild(routes)
12+
NativeScriptRouterModule.forChild(routes),
13+
NativeScriptCommonModule,
1414
],
1515
declarations: [NinjaComponent]
1616
})

Diff for: demo/AngularApp/app/ninjas/ninjas.module.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import { NativeScriptCommonModule } from "nativescript-angular/common";
12
import { NgModule, NO_ERRORS_SCHEMA } from "@angular/core";
2-
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33
import { NativeScriptRouterModule } from "nativescript-angular/router";
44

55
import { NinjasComponent } from "./ninjas.component";
@@ -8,9 +8,9 @@ import { routes } from "./ninjas.routes";
88
@NgModule({
99
schemas: [NO_ERRORS_SCHEMA],
1010
imports: [
11-
NativeScriptModule,
1211
NativeScriptRouterModule,
13-
NativeScriptRouterModule.forChild(routes)
12+
NativeScriptRouterModule.forChild(routes),
13+
NativeScriptCommonModule,
1414
],
1515
declarations: [NinjasComponent]
1616
})

Diff for: demo/JavaScriptApp/package.json

+7-4
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@
2424
"css-loader": "~0.28.7",
2525
"extract-text-webpack-plugin": "~3.0.0",
2626
"lazy": "1.0.11",
27+
"mocha": "~3.5.0",
28+
"mocha-junit-reporter": "^1.13.0",
29+
"mocha-multi": "^0.11.0",
2730
"nativescript-dev-appium": "next",
2831
"nativescript-dev-sass": "^1.3.5",
2932
"nativescript-dev-webpack": "file:../..",
@@ -32,9 +35,9 @@
3235
"raw-loader": "~0.5.1",
3336
"resolve-url-loader": "~2.1.0",
3437
"sass-loader": "^6.0.6",
35-
"webpack": "~3.8.1",
36-
"webpack-bundle-analyzer": "^2.8.2",
37-
"webpack-sources": "~1.0.1"
38+
"webpack": "~3.10.0",
39+
"webpack-bundle-analyzer": "^2.9.1",
40+
"webpack-sources": "^1.1.0"
3841
},
3942
"scripts": {
4043
"ns-bundle": "ns-bundle",
@@ -46,4 +49,4 @@
4649
"generate-android-snapshot": "generate-android-snapshot --targetArchs arm,arm64,ia32 --install",
4750
"e2e": "mocha --opts ./e2e/config/mocha.opts"
4851
}
49-
}
52+
}

0 commit comments

Comments
 (0)