Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 2f6c4e0

Browse files
fix(compiler): reject promise with real error
When the webpack compiler fails, the error is not used in the rejection, so the promise is always rejected with `undefined`. Fix this by respecting the error. Construct real error object as well.
1 parent 2972f03 commit 2f6c4e0

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

lib/compiler.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $mobileHelper,
2525
}
2626
resolveBase();
2727
}
28-
function reject() {
28+
function reject(error) {
2929
if (isResolved) return;
3030
isResolved = true;
3131
if (childProcess) {
3232
childProcess.removeListener("message", resolveOnWebpackCompilationComplete);
3333
}
34-
rejectBase();
34+
rejectBase(error);
3535
}
3636

3737
console.log(`Running webpack for ${config.platform}...`);
@@ -93,10 +93,9 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $mobileHelper,
9393
if (code === 0) {
9494
resolve();
9595
} else {
96-
reject({
97-
code,
98-
message: `child process exited with code ${code}`,
99-
});
96+
const error = new Error(`Executing webpack failed with exit code ${code}.`);
97+
error.code = code;
98+
reject(error);
10099
}
101100
});
102101
});

0 commit comments

Comments
 (0)