fix(template): create empty tns-java-classes.js internally (#148)

The tns-java-classes.js that is required for NativeScript 2.5 Android
builds is now create internally (GenerateStarterPlugin) instead as part
of CommonChunksPlugin.

Author: sis0k0

Diff for: index.js

@@ -52,10 +52,19 @@ exports.GenerateBundleStarterPlugin.prototype = {
         compiler.plugin("emit", function (compilation, cb) {
             compilation.assets["package.json"] = plugin.generatePackageJson();
             compilation.assets["starter.js"] = plugin.generateStarterModule();
+            plugin.generateTnsJavaClasses(compilation);
 
             cb();
         });
     },
+    generateTnsJavaClasses: function (compilation) {
+        const path = compilation.compiler.outputPath;
+        const isAndroid = path.indexOf("android") > -1;
+
+        if (isAndroid) {
+            compilation.assets["tns-java-classes.js"] = new sources.RawSource("");
+        }
+    },
     generatePackageJson: function () {
         var packageJsonPath = path.join(this.webpackContext, "package.json");
         var packageData = JSON.parse(fs.readFileSync(packageJsonPath, "utf8"));

Diff for: webpack.common.js.angular.template

@@ -19,19 +19,11 @@ module.exports = function (platform, destinationApp) {
     // app.css bundle
     entry["app.css"] = "./app.css";
 
-    // Vendor libs go to the vendor.js chunk
-    var commonsChunkNames = ["vendor"];
-
-    // Compatibility workaround with NativeScript 2.5 Android runtime
-    // https://github.com/NativeScript/NativeScript/issues/3947
-     if (platform === "android") {
-        commonsChunkNames.push("tns-java-classes");
-    }
-
     var plugins = [
         new ExtractTextPlugin("app.css"),
         new webpack.optimize.CommonsChunkPlugin({
-            name: commonsChunkNames
+            // Vendor libs go to the vendor.js chunk
+            name: ["vendor"]
         }),
         // Define useful constants like TNS_WEBPACK
         new webpack.DefinePlugin({

Diff for: webpack.common.js.javascript.template

@@ -18,19 +18,10 @@ module.exports = function (platform, destinationApp) {
     // app.css bundle
     entry["app.css"] = "./app.css";
 
-    // Vendor libs go to the vendor.js chunk
-    var commonsChunkNames = ["vendor"];
-
-    // Compatibility workaround with NativeScript 2.5 Android runtime
-    // https://github.com/NativeScript/NativeScript/issues/3947
-     if (platform === "android") {
-        commonsChunkNames.push("tns-java-classes");
-    }
-
     var plugins = [
         new ExtractTextPlugin("app.css"),
         new webpack.optimize.CommonsChunkPlugin({
-            name: commonsChunkNames
+            name: ["vendor"]
         }),
         // Define useful constants like TNS_WEBPACK
         new webpack.DefinePlugin({

Diff for: webpack.common.js.typescript.template

@@ -18,19 +18,10 @@ module.exports = function (platform, destinationApp) {
     // app.css bundle
     entry["app.css"] = "./app.css";
 
-    // Vendor libs go to the vendor.js chunk
-    var commonsChunkNames = ["vendor"];
-
-    // Compatibility workaround with NativeScript 2.5 Android runtime
-    // https://github.com/NativeScript/NativeScript/issues/3947
-     if (platform === "android") {
-        commonsChunkNames.push("tns-java-classes");
-    }
-
     var plugins = [
         new ExtractTextPlugin("app.css"),
         new webpack.optimize.CommonsChunkPlugin({
-            name: commonsChunkNames
+            name: ["vendor"]
         }),
         // Define useful constants like TNS_WEBPACK
         new webpack.DefinePlugin({