Merge pull request #49 from NativeScript/fatme/preverse-watch-output

Preserve watch output

Author: Fatme

lib/compiler.js

@@ -4,18 +4,35 @@ exports.getTscProcess = getTscProcess;
 var spawn = require('child_process').spawn;
 var fs = require('fs');
 var path = require('path');
+var semver = require('semver');
 var tsc = null;
 
+function getTypeScriptVersion(typeScriptPath) {
+	try {
+		return require(path.join(typeScriptPath, 'package.json')).version;
+	} catch (err) { }
+
+	return null;
+}
+
+function shouldPreserveWatchOutput(typeScriptVersion) {
+	try {
+		return semver.gte(typeScriptVersion, "2.8.1");
+	} catch (err) { }
+
+	return false;
+}
+
 function runTypeScriptCompiler(logger, projectDir, options) {
 	return new Promise(function (resolve, reject) {
 		options = options || {};
 
 		var peerTypescriptPath = path.join(__dirname, '../../typescript');
 		var tscPath = path.join(peerTypescriptPath, 'lib/tsc.js');
+		var typeScriptVersion = getTypeScriptVersion(peerTypescriptPath);
+		
 		if (fs.existsSync(tscPath)) {
-			try {
-				logger.info('Found peer TypeScript ' + require(path.join(peerTypescriptPath, 'package.json')).version);
-			} catch (err) { }
+			logger.info(`Found peer TypeScript ${typeScriptVersion}`);
 		} else {
 			throw Error('TypeScript installation local to project was not found. Install by executing `npm install typescript`.');
 		}
@@ -35,13 +52,21 @@ function runTypeScriptCompiler(logger, projectDir, options) {
 			nodeArgs.push('--inlineSourceMap', '--inlineSources');
 		}
 
+		if (this.shouldPreserveWatchOutput(typeScriptVersion)) {
+			nodeArgs.push('--preserveWatchOutput');
+		}
+
 		logger.trace(process.execPath, nodeArgs.join(' '));
 		tsc = spawn(process.execPath, nodeArgs);
 
 		var isResolved = false;
 		tsc.stdout.on('data', function (data) {
 			var stringData = data.toString();
-			logger.info(stringData);
+			// Prevent console clear. Fixed the behaviour for typescript 2.7.1 and 2.7.2. Should be deleted after dropping support for 2.7.x version.
+			// https://github.com/Microsoft/TypeScript/blob/master/src/compiler/sys.ts#L623
+			if (stringData !== "\x1Bc") {
+				logger.info(stringData);
+			}
 			if (options.watch && stringData.toLowerCase().indexOf("compilation complete. watching for file changes.") !== -1 && !isResolved) {
 				isResolved = true;
 				resolve();

package.json

@@ -40,6 +40,7 @@
     "url": "https://github.com/NativeScript/nativescript-dev-typescript.git"
   },
   "dependencies": {
-    "nativescript-hook": "^0.2.0"
+    "nativescript-hook": "^0.2.0",
+    "semver": "5.5.0"
   }
 }