Skip to content

feat: improve import handling for partials starting with _ prefix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NathanWalker
Copy link
Contributor

@toddanglin Love this plugin. This will make the import handling much better and standardized when handling partial imports. Standard is using _ prefixed files so given a sass structure like the following will work as expected:

app.scss
scss/
  _buttons.scss
  _variables.scss

where app.scss may look like this:

import 'scss/variables';
import 'scss/buttons';

And it will work without error since it will only actually compile app.scss to app.css and not compile 1-1 compiles for the partials which would cause an error with the other imports. 👍

After merging, please bump, and release! Thanks for great plugin.

@tjvantoll
Copy link

I’ll give my 👍 here. The SASS standard is to not output .css files for partials, and doing so was actually creating some problems for a few of us working on the new {N} theme.

@toddanglin toddanglin merged commit 1195bc9 into NativeScript:master Aug 17, 2016
@toddanglin
Copy link
Contributor

Great addition, Nathan! Thanks for contributing this improvement. Merged.

@toddanglin toddanglin mentioned this pull request Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants