Skip to content

[BreakingChange] compareElement parameters are not consistent with compareScreen #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zbranzov opened this issue Oct 7, 2019 · 0 comments
Open

[BreakingChange] compareElement parameters are not consistent with compareScreen #268

zbranzov opened this issue Oct 7, 2019 · 0 comments
Labels
breaking-change

Comments

@zbranzov
Copy link
Contributor

zbranzov commented Oct 7, 2019

compareElement(selected, "selectedState", 50, 5, ImageOptions.pixel) third parameter is the tolerance and I would expect to be the timeout as in compareScreen("initialState", 5, 50, ImageOptions.pixel); and it makes sense as I would rather use the timeout more frequently and then the tolerance paired with the ImageOptions
@zbranzov zbranzov changed the title compareElement parameters are not consistent with compareScreen [BreakingChange] compareElement parameters are not consistent with compareScreen Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zbranzov