Include guard for minimum required configurations.

Author: SvetoslavTsenov

e2e/config/appium.capabilities.json

@@ -7,8 +7,8 @@
         "lt": 60000,
         "appActivity": "com.tns.NativeScriptActivity",
         "newCommandTimeout": 720,
-        "noReset": false,
-        "fullReset": true,
+        "noReset": true,
+        "fullReset": false,
         "app": ""
     },
     "android21": {
@@ -19,8 +19,8 @@
         "lt": 60000,
         "appActivity": "com.tns.NativeScriptActivity",
         "newCommandTimeout": 720,
-        "noReset": false,
-        "fullReset": true,
+        "noReset": true,
+        "fullReset": false,
         "app": ""
     },
     "android23": {
@@ -31,8 +31,8 @@
         "lt": 60000,
         "appActivity": "com.tns.NativeScriptActivity",
         "newCommandTimeout": 720,
-        "noReset": false,
-        "fullReset": true,
+        "noReset": true,
+        "fullReset": false,
         "app": ""
     },
     "android24": {
@@ -43,8 +43,8 @@
         "lt": 60000,
         "appActivity": "com.tns.NativeScriptActivity",
         "newCommandTimeout": 720,
-        "noReset": false,
-        "fullReset": true,
+        "noReset": true,
+        "fullReset": false,
         "app": ""
     },
     "android25": {
@@ -55,8 +55,8 @@
         "lt": 60000,
         "appActivity": "com.tns.NativeScriptActivity",
         "newCommandTimeout": 720,
-        "noReset": false,
-        "fullReset": true,
+        "noReset": true,
+        "fullReset": false,
         "app": ""
     },
     "android26": {
@@ -67,8 +67,8 @@
         "lt": 60000,
         "appActivity": "com.tns.NativeScriptActivity",
         "newCommandTimeout": 720,
-        "noReset": false,
-        "fullReset": true,
+        "noReset": true,
+        "fullReset": false,
         "app": ""
     },
     "sim.iPhone7.iOS100": {

lib/appium-driver.ts

@@ -340,15 +340,6 @@ export class AppiumDriver {
         const driver = await wd.promiseChainRemote(driverConfig);
         AppiumDriver.configureLogging(driver, args.verbose);
 
-        if (args.appPath) {
-            args.appiumCaps.app = args.appPath;
-        }
-
-        if (!args.appiumCaps.app) {
-            log("Getting caps.app!", args.verbose);
-            args.appiumCaps.app = getAppPath(args.appiumCaps.platformName.toLowerCase(), args.runType.toLowerCase());
-        }
-
         if (args.isSauceLab) {
             const sauceUser = process.env.SAUCE_USER;
             const sauceKey = process.env.SAUCE_KEY;
@@ -362,6 +353,7 @@ export class AppiumDriver {
             }
 
             args.appiumCaps.app = "sauce-storage:" + args.appiumCaps.app
+            console.log("Using Sauce Labs. The application path is changed to: " + args.appiumCaps.app);
         }
 
         log("Creating driver!", args.verbose);

lib/appium-server.ts

@@ -1,5 +1,5 @@
 import * as child_process from "child_process";
-import { log, resolve, waitForOutput, shutdown, fileExists, isWin } from "./utils";
+import { log, resolve, waitForOutput, shutdown, fileExists, isWin, executeCommand } from "./utils";
 import { INsCapabilities } from "./ins-capabilities";
 import { SimulatorManager } from "./simulator-manager";
 import { EmulatorManager } from "./emulator-manager";
@@ -132,7 +132,14 @@ export class AppiumServer {
             log("Using project-local Appium binary.", this._args.verbose);
             appium = projectAppiumBinary;
         } else {
-            log("Using global Appium binary.", this._args.verbose);
+            const result = executeCommand("npm list -g");
+            if (result.includes("appium")) {
+                log("Using global Appium binary.", this._args.verbose);
+            } else if (result.includes("appium")) {
+                const msg = "Appium not found. Please install appium before runnig tests!";
+                log(msg, this._args.verbose);
+                new Error(msg);
+            }
         }
 
         this._appium = appium;

lib/ns-capabilities.d.ts

@@ -16,6 +16,7 @@ export declare class NsCapabilities implements INsCapabilities {
     private _isSauceLab;
     private _appPath;
     private _emulatorOptions;
+    private exceptions;
     constructor();
     readonly projectDir: any;
     readonly projectBinary: any;
@@ -33,4 +34,7 @@ export declare class NsCapabilities implements INsCapabilities {
     readonly isSauceLab: any;
     appPath: string;
     readonly emulatorOptions: string;
+    private resolveAppPath();
+    private checkMendatoryCapabiliies();
+    private throwExceptions();
 }

lib/ns-capabilities.ts

@@ -1,6 +1,7 @@
 import * as parser from "./parser"
 import { INsCapabilities } from "./ins-capabilities";
 import { resolveCapabilities } from "./capabilities-helper";
+import { getAppPath, fileExists, logErr } from "./utils";
 
 export class NsCapabilities implements INsCapabilities {
     private _projectDir;
@@ -19,6 +20,7 @@ export class NsCapabilities implements INsCapabilities {
     private _isSauceLab;
     private _appPath: string;
     private _emulatorOptions: string;
+    private exceptions: Array<string> = new Array();
 
     constructor() {
         this._projectDir = parser.projectDir;
@@ -36,6 +38,8 @@ export class NsCapabilities implements INsCapabilities {
         this._runType = parser.runType;
         this._isSauceLab = parser.isSauceLab;
         this._appiumCaps = resolveCapabilities(this._appiumCapsLocation, parser.runType, parser.projectDir);
+        this.resolveAppPath();
+        this.checkMendatoryCapabiliies()
     }
 
     get projectDir() { return this._projectDir; }
@@ -55,4 +59,50 @@ export class NsCapabilities implements INsCapabilities {
     get appPath() { return this._appPath; }
     set appPath(appPath: string) { this._appPath = appPath; }
     get emulatorOptions() { return (this._emulatorOptions || "-wipe-data -gpu on") }
+
+    private resolveAppPath() {
+
+        if (this._appPath) {
+            this._appiumCaps.app = this._appPath;
+        }
+
+        if (!this._appiumCaps.app) {
+            this._appiumCaps.app = getAppPath(this._appiumCaps.platformName.toLowerCase(), this._runType.toLowerCase());
+        }
+
+        console.log("Application full path: " + this._appiumCaps.app);
+    }
+
+    private checkMendatoryCapabiliies() {
+        if (!fileExists(this._appiumCaps.appPath)) {
+            this.exceptions.push("The application folder doesn't exist!");
+        }
+
+        if (!this._appiumCaps._runType) {
+            this.exceptions.push("Missing runType! Please select one from appium capabilities file!");
+        }
+
+        if (this._appiumCaps.platformName) {
+            this.exceptions.push("Platform name is missing! Please, check appium capabilities file!");
+        }
+
+        if (this._appiumCaps.platformName) {
+            this.exceptions.push("Platform version is missing! Please, check appium capabilities file!");
+        }
+
+        if (this._appiumCaps.deviceName && this._appiumCaps.uidid) {
+            this.exceptions.push("The device name or uidid are missing! Please, check appium capabilities file!");
+        }
+    }
+
+    private throwExceptions() {
+        this.exceptions.forEach(msg => {
+            logErr(msg, true);
+        });
+
+        if (this.exceptions.length > 0) {
+            const messagesString = this.exceptions.length > 1 ? "messages" : "message";
+            throw new Error(`See the ${messagesString} above and fullfill the conditions!!!`);
+        }
+    }
 }