From ce3374e4047d04835be92334a2d65a96124df32b Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Tue, 28 Apr 2020 00:26:47 +0200 Subject: [PATCH 1/2] feat: allow modifying gradlew args in hooks --- lib/services/android/gradle-build-args-service.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/services/android/gradle-build-args-service.ts b/lib/services/android/gradle-build-args-service.ts index be3c354079..bb13547a80 100644 --- a/lib/services/android/gradle-build-args-service.ts +++ b/lib/services/android/gradle-build-args-service.ts @@ -3,6 +3,7 @@ import { Configurations } from "../../common/constants"; export class GradleBuildArgsService implements IGradleBuildArgsService { constructor(private $androidToolsInfo: IAndroidToolsInfo, + private $hooksService: IHooksService, private $analyticsService: IAnalyticsService, private $staticConfig: Config.IStaticConfig, private $logger: ILogger) { } @@ -15,6 +16,9 @@ export class GradleBuildArgsService implements IGradleBuildArgsService { args.push("-PgatherAnalyticsData=true"); } + // allow modifying gradle args from a `before-build-task-args` hook + await this.$hooksService.executeBeforeHooks('build-task-args', { hookArgs: { args } }); + return args; } From 36283692465b65ccff710ce209d7d8224ecb0287 Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Tue, 28 Apr 2020 00:51:46 +0200 Subject: [PATCH 2/2] test: update failing tests --- test/services/android/gradle-build-args-service.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/test/services/android/gradle-build-args-service.ts b/test/services/android/gradle-build-args-service.ts index e9c1a4428a..22942c525c 100644 --- a/test/services/android/gradle-build-args-service.ts +++ b/test/services/android/gradle-build-args-service.ts @@ -16,6 +16,7 @@ function createTestInjector(): IInjector { }) }); injector.register("logger", {}); + injector.register("hooksService", stubs.HooksServiceStub); injector.register("gradleBuildArgsService", GradleBuildArgsService); injector.register("analyticsService", stubs.AnalyticsService); injector.register("staticConfig", {TRACK_FEATURE_USAGE_SETTING_NAME: "TrackFeatureUsage"});