From 2d354bff8a0d3cf1d1e6b95b12db02cea13fce8f Mon Sep 17 00:00:00 2001 From: fatme Date: Thu, 27 Jun 2019 08:49:45 +0300 Subject: [PATCH 1/2] fix: respect --provision on deploy command Currently when `tns deploy ios --provision ` is executed, CLI shows a prompt for teamId as the provision option is not respected. --- lib/helpers/deploy-command-helper.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/helpers/deploy-command-helper.ts b/lib/helpers/deploy-command-helper.ts index c010c96522..ffc6ac0a89 100644 --- a/lib/helpers/deploy-command-helper.ts +++ b/lib/helpers/deploy-command-helper.ts @@ -51,7 +51,7 @@ export class DeployCommandHelper { }); await this.$deployController.deploy({ - buildData: this.$buildDataService.getBuildData(this.$projectData.projectDir, platform, { ...this.$options, skipWatcher: !this.$options.watch }), + buildData: this.$buildDataService.getBuildData(this.$projectData.projectDir, platform, { ...this.$options.argv, skipWatcher: !this.$options.watch }), deviceDescriptors }); } From 95cbb999d1ec9e62c8c00b969174ff14095c6971 Mon Sep 17 00:00:00 2001 From: fatme Date: Thu, 27 Jun 2019 10:54:54 +0300 Subject: [PATCH 2/2] fix: fix cannot read property projectDir of undefined --- lib/services/log-source-map-service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/services/log-source-map-service.ts b/lib/services/log-source-map-service.ts index 5842c87185..fb9e47c677 100644 --- a/lib/services/log-source-map-service.ts +++ b/lib/services/log-source-map-service.ts @@ -53,7 +53,7 @@ export class LogSourceMapService implements Mobile.ILogSourceMapService { } public replaceWithOriginalFileLocations(platform: string, messageData: string, loggingOptions: Mobile.IDeviceLogOptions): string { - if (!messageData || !loggingOptions.projectDir) { + if (!messageData || !loggingOptions || !loggingOptions.projectDir) { return messageData; }