fix: don't check all node_modules from checkForChanges method
#4671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
commented
Jun 3, 2019
…orChanges method Rel to: #4647
modulesChange property was used to indicate .js change in node_modules but webpack watches for changes in `.js` files from node_modules if they are required in application, so no more need from this property.
Fatme
force-pushed
the
fatme/project-changes
branch
from
f9850cb to
5f50f67
Compare
Chokidar raises changed event when `.js` file is changed from within symlinked plugin and this led to a native build on every .js change for plugin's developer. As a workaround, we checked if there are native changes and rebuild the project only in this case.
Fatme
force-pushed
the
fatme/project-changes
branch
from
5f50f67 to
7e79e0b
Compare
rosen-vladimirov
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel to: #4647
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].