From 1060aaaa403ee74c5141b795ae9e4eb04b437c15 Mon Sep 17 00:00:00 2001 From: fatme Date: Tue, 2 Apr 2019 16:24:34 +0300 Subject: [PATCH] fix: change ksplay to kspreview schema --- .../livesync/playground/preview-qr-code-service.ts | 2 +- .../livesync/playground/preview-schema-service.ts | 4 ++-- test/services/playground/preview-schema-service.ts | 10 +++++----- test/services/preview-sdk-service.ts | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/services/livesync/playground/preview-qr-code-service.ts b/lib/services/livesync/playground/preview-qr-code-service.ts index 4d369c22e8..2609a2cd55 100644 --- a/lib/services/livesync/playground/preview-qr-code-service.ts +++ b/lib/services/livesync/playground/preview-qr-code-service.ts @@ -16,7 +16,7 @@ export class PreviewQrCodeService implements IPreviewQrCodeService { @exported("previewQrCodeService") public async getPlaygroundAppQrCode(options?: IPlaygroundAppQrCodeOptions): Promise> { - const { projectDir } = options; + const { projectDir } = options || { }; const result = Object.create(null); if (!options || !options.platform || this.$mobileHelper.isAndroidPlatform(options.platform)) { diff --git a/lib/services/livesync/playground/preview-schema-service.ts b/lib/services/livesync/playground/preview-schema-service.ts index f1423fc82a..a75e49b54d 100644 --- a/lib/services/livesync/playground/preview-schema-service.ts +++ b/lib/services/livesync/playground/preview-schema-service.ts @@ -13,8 +13,8 @@ export class PreviewSchemaService implements IPreviewSchemaService { subscribeKey: PubnubKeys.SUBSCRIBE_KEY, default: true }, - "ksplay": { - name: "ksplay", + "kspreview": { + name: "kspreview", scannerAppId: "com.kinvey.scanner", scannerAppStoreId: "1263543946", previewAppId: "com.kinvey.preview", diff --git a/test/services/playground/preview-schema-service.ts b/test/services/playground/preview-schema-service.ts index b2f279c315..a8bce302ae 100644 --- a/test/services/playground/preview-schema-service.ts +++ b/test/services/playground/preview-schema-service.ts @@ -24,8 +24,8 @@ const nsPlaySchema = { default: true }; -const ksPlaySchema = { - name: 'ksplay', +const ksPreviewSchema = { + name: 'kspreview', scannerAppId: 'com.kinvey.scanner', scannerAppStoreId: '1263543946', previewAppId: 'com.kinvey.preview', @@ -56,9 +56,9 @@ describe("PreviewSchemaService", () => { expectedSchema: nsPlaySchema }, { - name: "should return ksplay schema when { 'previewAppSchema': 'ksplay' } in nsconfig", - previewAppSchema: "ksplay", - expectedSchema: ksPlaySchema + name: "should return kspreview schema when { 'previewAppSchema': 'kspreview' } in nsconfig", + previewAppSchema: "kspreview", + expectedSchema: ksPreviewSchema }, { name: "should throw an error when invalid previewAppSchema is specified in nsconfig", diff --git a/test/services/preview-sdk-service.ts b/test/services/preview-sdk-service.ts index 98a82b8b9e..464cd570ec 100644 --- a/test/services/preview-sdk-service.ts +++ b/test/services/preview-sdk-service.ts @@ -54,8 +54,8 @@ describe('PreviewSdkService', () => { }, { name: "should return the schema from nsconfig", - schemaFromNsConfig: "ksplay", - expectedSchemaName: "ksplay" + schemaFromNsConfig: "kspreview", + expectedSchemaName: "kspreview" }, { name: "should return the default schema",