From 5d955df51852c15d3d6244dc5e0c4c33a4988e60 Mon Sep 17 00:00:00 2001 From: DimitarTachev Date: Wed, 20 Mar 2019 16:39:34 +0200 Subject: [PATCH] fix: remove the HMR Beta warnings as all critical issue are fixed --- lib/services/livesync/livesync-service.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/services/livesync/livesync-service.ts b/lib/services/livesync/livesync-service.ts index 1ab42551d7..ac432d49f6 100644 --- a/lib/services/livesync/livesync-service.ts +++ b/lib/services/livesync/livesync-service.ts @@ -50,7 +50,6 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi public async liveSync(deviceDescriptors: ILiveSyncDeviceInfo[], liveSyncData: ILiveSyncInfo): Promise { const projectData = this.$projectDataService.getProjectData(liveSyncData.projectDir); - this.handleWarnings(liveSyncData, projectData); await this.$pluginsService.ensureAllDependenciesAreInstalled(projectData); await this.liveSyncOperation(deviceDescriptors, liveSyncData, projectData); } @@ -145,12 +144,6 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi } } - private handleWarnings(liveSyncData: ILiveSyncInfo, projectData: IProjectData) { - if (liveSyncData.useHotModuleReload) { - this.$logger.warn("Hot Module Replacement (HMR) is currently in Beta. For more information about the current development state and any known issues, please check the relevant GitHub issue: https://github.com/NativeScript/NativeScript/issues/6398"); - } - } - @performanceLog() private async refreshApplication(projectData: IProjectData, liveSyncResultInfo: ILiveSyncResultInfo, debugOpts?: IDebugOptions, outputPath?: string): Promise { const deviceDescriptor = this.getDeviceDescriptor(liveSyncResultInfo.deviceAppData.device.deviceInfo.identifier, projectData.projectDir);