Skip to content

chore: remove outdated warnings #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

chore: remove outdated warnings #4337

merged 1 commit into from
Feb 6, 2019

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

These warnings will be misleading after NativeScript/nativescript-dev-webpack#788 which will be available with CLI 5.2.0.

rosen-vladimirov
rosen-vladimirov approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After green build

@DimitarTachev DimitarTachev force-pushed the tachev/remove-warnings branch from edce4e6 to 5512d09 Compare February 6, 2019 14:05
@DimitarTachev DimitarTachev force-pushed the tachev/remove-warnings branch from 5512d09 to 21c29e8 Compare February 6, 2019 14:06
@Fatme
Copy link
Contributor

Fatme commented Feb 6, 2019

run ci

1 similar comment
@DimitarTachev
Copy link
Contributor Author

run ci

@DimitarTachev DimitarTachev merged commit 37d0f6f into master Feb 6, 2019
@DimitarTachev DimitarTachev deleted the tachev/remove-warnings branch February 6, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitarTachev @Fatme @rosen-vladimirov