Skip to content

fix: error may be raised during restart of app on ios Sim #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

On slower mac machines, an error may be raised during restart of app on iOS Simulator. The problem is that we stop the application and try to start it after that. However, the stop method may be resolved before the application is actually killed. Trying to start it after that leads to undefined behavior and errors in some cases.
To fix this, update ios-sim-portable to 4.0.8 where a possible fix is applied.

PR Checklist

What is the current behavior?

On slower mac machines trying to use tns run ios --emulator leads to error while restarting the app.

What is the new behavior?

CLI should be able to restart the app on all machines and tns run ios --emulator should work.

On slower mac machines, an error may be raised during restart of app on iOS Simulator. The problem is that we stop the application and try to start it after that. However, the stop method may be resolved before the application is actually killed. Trying to start it after that leads to undefined behavior and errors in some cases.
To fix this, update ios-sim-portable to 4.0.8 where a possible fix is applied.
@rosen-vladimirov rosen-vladimirov added this to the 5.1.1 milestone Jan 17, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Jan 17, 2019
@rosen-vladimirov rosen-vladimirov merged commit 793881d into release Jan 17, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-ios-sim-stop-app branch January 17, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants