From 88c802840229f5881c61292a3d64864867066afe Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Mon, 8 Oct 2018 17:06:51 +0300 Subject: [PATCH] feat: set min required compile Android SDK to 28 As we are going to set min required Android Support Library to be 28 (in the modules), we need to set the min required compile SDK to 28 as well (as Android Support Library 28 relies on resources included in this version of the SDK and the project cannot be build without them). This way CLI will not allow building an application without installing the Android SDK 28 first. --- lib/android-tools-info.ts | 2 +- npm-shrinkwrap.json | 6 +++--- package.json | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/android-tools-info.ts b/lib/android-tools-info.ts index d0d47ac3c4..5a00d32f34 100644 --- a/lib/android-tools-info.ts +++ b/lib/android-tools-info.ts @@ -18,7 +18,7 @@ export class AndroidToolsInfo implements IAndroidToolsInfo { "android-27", "android-28", ]; - private static MIN_REQUIRED_COMPILE_TARGET = 22; + private static MIN_REQUIRED_COMPILE_TARGET = 28; private static REQUIRED_BUILD_TOOLS_RANGE_PREFIX = ">=23"; private static VERSION_REGEX = /((\d+\.){2}\d+)/; diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json index cc7b9a0ca6..eb28187eab 100644 --- a/npm-shrinkwrap.json +++ b/npm-shrinkwrap.json @@ -5100,9 +5100,9 @@ "integrity": "sha512-1pJ+02gl2KJgCPFtpZGtuD4lGSJnIZvvFHCQTOeDRMSXjfu2GmYWuhI8NFMA4W2I5NNFRbfy/YCiVt4CgNpP8A==" }, "nativescript-doctor": { - "version": "1.5.0", - "resolved": "https://registry.npmjs.org/nativescript-doctor/-/nativescript-doctor-1.5.0.tgz", - "integrity": "sha512-gxDRor5HWfWLTBO+QvOoP8YAyGs24U70CFeezq6PRT08ONkZQLg4aEVSzhAHYiRsAnmS2GTDpzXKQj93NEaU2g==", + "version": "1.6.0", + "resolved": "https://registry.npmjs.org/nativescript-doctor/-/nativescript-doctor-1.6.0.tgz", + "integrity": "sha512-TOjRseq2LqUVofoWVXsWPuaxZkMJKtvTS+U6mwuDt3X2d7DgHis54mckIdSEIZw9QdeC+Q15lggEeOWIpPON1Q==", "requires": { "osenv": "0.1.3", "semver": "5.5.1", diff --git a/package.json b/package.json index 5330add28e..7fe709407e 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "minimatch": "3.0.2", "mkdirp": "0.5.1", "mute-stream": "0.0.5", - "nativescript-doctor": "1.5.0", + "nativescript-doctor": "1.6.0", "nativescript-preview-sdk": "0.3.0", "open": "0.0.5", "ora": "2.0.0",