From bf252c99ae145ddebcc8a2f9678befdb0534cb73 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Mon, 17 Sep 2018 10:50:38 +0300 Subject: [PATCH 1/2] fix: unable to work with devices with numeric identifiers In case the device identifier contains only numeric symbols or in case it looks like a number (16089e09 for example), CLI fails to work with it. The problem is that CLI thinks an index is passed to it, so it removes "one" from the passed number and tries to find the device on the new index. The other issue is with the `isNumber` helper method which works incorrectly when the string looks like number. Improve the logic in the method and rename it. We cannot parse safely values with exponent (`1e6` for example), but we do not need such functionality. The new method name and tests reflects the described behavior. Before using the identifier as an index, check if we'll find device with the specified identifier. --- lib/common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common b/lib/common index e6ccad85bd..92545e4d08 160000 --- a/lib/common +++ b/lib/common @@ -1 +1 @@ -Subproject commit e6ccad85bdb1309b91155584a4cf4c36d4ab33b4 +Subproject commit 92545e4d08c655e95d1acb5c931bffa3f54d0eff From cb5e390b753dcb08ee7b08eef56da2c06a17555a Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Mon, 17 Sep 2018 10:58:05 +0300 Subject: [PATCH 2/2] docs: update Changelog for 4.2.4 --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b15be298e5..b5bf627719 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,11 @@ NativeScript CLI Changelog ================ -4.2.4 (2018, September 17) +4.2.4 (2018, September 19) == ### Fixed +* [Fixed #3832](https://github.com/NativeScript/nativescript-cli/issues/3832): Unable to work with devices with numeric identifiers * [Fixed #3881](https://github.com/NativeScript/nativescript-cli/pull/3881): Replace forum references with stack overflow. * [Fixed #3883](https://github.com/NativeScript/nativescript-cli/issues/3883): CLI installs the app on every change * [Fixed #3893](https://github.com/NativeScript/nativescript-cli/pull/3893): [API] Errors are raised when emulator lost/found event is raised.