From 02a1ec92ba64abb046ac286ba21b328ac2f0b558 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Fri, 14 Sep 2018 08:36:08 +0300 Subject: [PATCH] fix: emulator API fixes fix: errors are raised when emulator lost/found event is raised Whenever androidEmulatorDiscovery raises `emulatorImageFound` or `emulatorImageLost` event, an error is raised in the code as `devicesService` expects to receive an array, but it receives a single image instead. Fix the code in devicesService to handle correctly the event. Also add logic to handle the same events from iOSSimulatorDiscovery. fix: Android emulator images are not correct In case the Android Emulator image does not have displayName set in the config.ini file, the displayName that CLI sets fallbacks to `hw.device.name` property. However, this name is not the one that is visible in other tools, like Android Studio for example. As a user I expect to see the same name as in Android Studio. In order to fix this, fallback to the AvdId value from config.ini file and if it is missing, fallback to `hw.device.name`. --- lib/common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common b/lib/common index e10226523e..e6ccad85bd 160000 --- a/lib/common +++ b/lib/common @@ -1 +1 @@ -Subproject commit e10226523e84fbe5d57c1f8bb1c02d9171316280 +Subproject commit e6ccad85bdb1309b91155584a4cf4c36d4ab33b4